use badge for historical message indicator

tommyxchow · Dec 23, 2024 · 80837be · 80837be
1 parent 817289a
commit 80837be
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 44 deletions.
diff --git a/lib/models/irc.dart b/lib/models/irc.dart
@@ -170,6 +170,21 @@ class IRCMessage {
       }
     }
 
+    final isHistorical = tags['historical'] == '1';
+    if (isHistorical) {
+      span.add(
+        WidgetSpan(
+          child: Tooltip(
+            message: 'Historical message',
+            preferBelow: false,
+            triggerMode: TooltipTriggerMode.tap,
+            child: Icon(Icons.history_rounded, size: badgeSize),
+          ),
+        ),
+      );
+      span.add(const TextSpan(text: ' '));
+    }
+
     final sourceChannelId = tags['source-room-id'] ?? tags['room-id'];
     final sourceChannelUser = channelIdToUserTwitch != null
         ? channelIdToUserTwitch[sourceChannelId]

diff --git a/lib/screens/channel/chat/widgets/chat_message.dart b/lib/screens/channel/chat/widgets/chat_message.dart
@@ -456,15 +456,6 @@ class ChatMessage extends StatelessWidget {
           child: coloredMessage,
         );
 
-        final isHistorical = ircMessage.tags['historical'] == '1';
-
-        if (chatStore.settings.darkenRecentMessages && isHistorical) {
-          return Opacity(
-            opacity: 0.5,
-            child: finalMessage,
-          );
-        }
-
         return finalMessage;
       },
     );

diff --git a/lib/screens/settings/chat_settings.dart b/lib/screens/settings/chat_settings.dart
@@ -372,15 +372,6 @@ class _ChatSettingsState extends State<ChatSettings> {
             onChanged: (newValue) =>
                 settingsStore.showRecentMessages = newValue,
           ),
-          SettingsListSwitch(
-            title: 'Darken historical recent messages',
-            subtitle: const Text(
-              'Makes historical recent messages 50% opacity to distinguish them from live messages.',
-            ),
-            value: settingsStore.darkenRecentMessages,
-            onChanged: (newValue) =>
-                settingsStore.darkenRecentMessages = newValue,
-          ),
         ],
       ),
     );

diff --git a/lib/screens/settings/stores/settings_store.dart b/lib/screens/settings/stores/settings_store.dart
@@ -162,7 +162,6 @@ abstract class _SettingsStoreBase with Store {
 
   // Recent messages defaults
   static const defaultShowRecentMessages = false;
-  static const defaultDarkenRecentMessages = true;
 
   // Message sizing options
   @JsonKey(defaultValue: defaultBadgeScale)
@@ -301,10 +300,6 @@ abstract class _SettingsStoreBase with Store {
   @observable
   var showRecentMessages = defaultShowRecentMessages;
 
-  @JsonKey(defaultValue: defaultDarkenRecentMessages)
-  @observable
-  var darkenRecentMessages = defaultDarkenRecentMessages;
-
   @JsonKey(defaultValue: defaultMutedWords)
   @observable
   List<String> mutedWords = defaultMutedWords;
@@ -358,7 +353,6 @@ abstract class _SettingsStoreBase with Store {
     showFFZBadges = defaultShowFFZBadges;
 
     showRecentMessages = defaultShowRecentMessages;
-    darkenRecentMessages = defaultDarkenRecentMessages;
   }
 
   // * Other settings

diff --git a/lib/screens/settings/stores/settings_store.g.dart b/lib/screens/settings/stores/settings_store.g.dart