-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to mute keywords from chat #413
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Created a json converter to to serialize the observable list of muted keywords, this required a static method for the default value. Also moved the logic for the muted keyword widget to the widget itself
I made the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty cool solution but for this case and simplicity, I think we should just use a normal list/array, then instead of mutating the list/array, re-assign it in an immutable style so that Mobx will detect that the variable changed.
Sounds good, I’ve made the changes. It was indeed a bit overkill, perhaps! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you so much!
This PR adds the ability for users to mute specific keywords in the chat.
It adds a section in the chat settings. Besides the bottom sheet with a text field, there is a switch that makes the app only match whole words instead of words containing the keyword (for example, if someone wants to mute "W"s but doesn't want words with "w" to be filtered).
Related to issue #400
demo_muted_words_1731245646.mp4