-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added: my solutions in javascript to the caesar cipher challenge #76
base: main
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,69 @@ | ||
const letters = 26; | ||
|
||
function encode(str, shift) { | ||
shift = shift % letters | ||
|
||
return str.split("").map(character => { | ||
// if is a letter | ||
if ((character >= "a" && character <= "z") || (character >= "A" && character <= "Z")) { | ||
// if is lowercase | ||
if (character >= "a" && character <= "z") { | ||
ascii = 97 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Where does this |
||
} | ||
// if is uppercase | ||
else { | ||
ascii = 65 | ||
} | ||
|
||
new_str = letters + character.charCodeAt(0) - ascii | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please instantiate a new variable by using |
||
new_str = (new_str + shift) % letters | ||
encrypt = String.fromCharCode(new_str + ascii) | ||
return encrypt | ||
} | ||
// don't encrypt if it's not a letter | ||
else return character; | ||
}).join(""); | ||
} | ||
|
||
|
||
function decode(str, shift) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Here you're repeating most of the |
||
shift = shift % letters | ||
|
||
return str.split("").map(character => { | ||
// if is a letter | ||
if ((character >= "a" && character <= "z") || (character >= "A" && character <= "Z")) { | ||
// if is lowercase | ||
if (character >= "a" && character <= "z") { | ||
ascii = 97 | ||
} | ||
// if is uppercase | ||
else { | ||
ascii = 65 | ||
} | ||
|
||
new_str = letters + character.charCodeAt(0) - ascii | ||
new_str = (new_str - shift) % letters | ||
decrypt = String.fromCharCode(new_str + ascii) | ||
return decrypt | ||
} | ||
else return character; | ||
}).join(""); | ||
} | ||
|
||
|
||
/* | ||
|
||
// encode test | ||
console.log(encode('Hello, World!', 7)); // => 'Olssv, Dvysk!' | ||
console.log(encode('I love pizza.', -7)); // => 'B ehox ibsst.' | ||
console.log(encode('HytyQapgnr kyicq qclqc. Qmkcrgkcq.', 50)); // => 'HytyQapgnr kyicq qclqc. Qmkcrgkcq.' | ||
console.log(encode('abc', 24)); // => 'yza' | ||
|
||
|
||
// decode test | ||
console.log(decode('CxvxaaxfMneb Axltb!', 9)); // => 'TomorrowDevs Rocks!' | ||
console.log(decode('Gtdflw Defotz Nzop td rcple!!!', -15)); // => 'Visual Studio Code is great!!!' | ||
console.log(decode('Vriwzduh Hqjlqhhulqj', 3)); // => 'Software Engineering' | ||
console.log(decode("Buj'i mhyju jxu syfxuh.", 120)); // => "Let's write the cipher." | ||
|
||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create a new constant value instead of re-assigning the function parameter 🙂