[Fix] Early out of bounced messages #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e6654321
force-pushed
the
fix/bounced-op-check
branch
from
29ba22b
to
d6aa44b
Compare
Walker-ctrl
approved these changes
Sep 28, 2024
MASOODMND
approved these changes
Nov 1, 2024
| @@ -33,6 +33,7 @@ const int size::query_id = 64; | |||
| const int prefix::signed_external = 0x7369676E; | |||
| const int prefix::signed_internal = 0x73696E74; | |||
| const int prefix::extension_action = 0x6578746E; | |||
| const int prefix::bounced = 0xffffff; | |||
|
|
|||
| @@ -33,6 +33,7 @@ const int size::query_id = 64; | |||
| const int prefix::signed_external = 0x7369676E; | |||
| const int prefix::signed_internal = 0x73696E74; | |||
| const int prefix::extension_action = 0x6578746E; | |||
| const int prefix::bounced = 0xffffff; | |||
There was a problem hiding this comment.
Suggested change
| const int prefix::bounced = 0xffffff; | |
| const int prefix::bounced = 0xffffff; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the need to check for bounced messages early and applies the early return principle to minimize gas and storage costs. Additionally, this approach helps prevent potentially damaging bugs that could arise from internal message injection attacks.
File Changes
contracts/wallet_v5.fc