Use the package name in the pin first argument instead of the new for…

…mat (so it works on all installs)
tonysm · Feb 4, 2024 · ac86d49 · ac86d49
1 parent 0cfdcb1
commit ac86d49
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/Npm.php b/src/Npm.php
@@ -95,7 +95,7 @@ private function findPackagesFromCdnMatches(string $content)
 
     private function findPackagesFromLocalMatches(string $content)
     {
-        preg_match_all('/^Importmap::pin\(.+\)\;\s*\/\/\s*(.+?)@(.+?)\s+.*\r?$/m', $content, $matches);
+        preg_match_all('/^Importmap::pin\([\'\"](.+?)[\'\"].*\)\;\s*\/\/\s*.*@(.+?)\s+.*\r?$/m', $content, $matches);
 
         if (count($matches) !== 3) {
             return collect();

diff --git a/tests/fixtures/npm/audit-importmap.php b/tests/fixtures/npm/audit-importmap.php
@@ -3,4 +3,4 @@
 use Tonysm\ImportmapLaravel\Facades\Importmap;
 
 Importmap::pin('is-svg', to: 'https://cdn.skypack.dev/[email protected]', preload: true);
-Importmap::pin('lodash', to: '/js/vendor/lodash.js'); // lodash@4.17.12
+Importmap::pin('lodash', to: '/js/vendor/lodash.js'); // @4.17.12
diff --git a/tests/fixtures/npm/outdated-importmap.php b/tests/fixtures/npm/outdated-importmap.php
@@ -3,4 +3,4 @@
 use Tonysm\ImportmapLaravel\Facades\Importmap;
 
 Importmap::pin('is-svg', to: 'https://cdn.skypack.dev/[email protected]', preload: true);
-Importmap::pin('lodash', to: '/js/vendor/lodash.js'); // lodash@4.0.0
+Importmap::pin('lodash', to: '/js/vendor/lodash.js'); // @4.0.0