Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix outdated command breaks on previous comment format #50

Merged
merged 6 commits into from
Feb 4, 2024
+5 −5
Merged

Fix outdated command breaks on previous comment format #50

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ac86d49
Use the package name in the pin first argument instead of the new for…
tonysm Feb 4, 2024
e82aa3e
Include tag modifiers in the version (beta, alpha, etc)
tonysm Feb 4, 2024
e68f2bf
Handle packages that have an at symbol at the name
tonysm Feb 4, 2024
e81481c
Another attempt at matching packages starting with at symbols
tonysm Feb 4, 2024
c7a73ef
Fix local package and version matching
tonysm Feb 4, 2024
3c1f08c
Ensure the pin command updates the package line when exists
tonysm Feb 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Handle packages that have an at symbol at the name
@tonysm
tonysm committed Feb 4, 2024
commit e68f2bfe7bae3031100d14668694e2c85dbb0dec
2 changes: 1 addition & 1 deletion src/Npm.php
View file
Original file line number Diff line number Diff line change
@@ -95,7 +95,7 @@ private function findPackagesFromCdnMatches(string $content)

private function findPackagesFromLocalMatches(string $content)
{
preg_match_all('/^Importmap::pin\([\'\"](.+?)[\'\"].*\)\;\s*\/\/\s*.*@(.+?)\s+.*\r?$/m', $content, $matches);
preg_match_all('/^Importmap::pin\([\'\"](.+?)[\'\"].*\)\;\s*\/\/\s*.*@(\d+\.\d+\.\d+.*?)\s+.*\r?$/m', $content, $matches);

if (count($matches) !== 3) {
return collect();