Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update pip if extern managed and global.break-system-packages is true #634

Merged
merged 1 commit into from
Dec 30, 2023

Conversation

SteveLauC
Copy link
Member

Standards checklist:

  • The PR title is descriptive.
  • I have read CONTRIBUTING.md
  • The code compiles (cargo build)
  • The code passes rustfmt (cargo fmt)
  • The code passes clippy (cargo clippy)
  • The code passes tests (cargo test)
  • Optional: I have tested the code myself

For new steps

  • Optional: Topgrade skips this step where needed
  • Optional: The --dry-run option works with this step
  • Optional: The --yes option works with this step if it is supported by
    the underlying command

If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.

Closes #631

From the information provided in #631, even though a pip3 is externally managed, we should still update it if global.break-system-packages is set to true.

@SteveLauC
Copy link
Member Author

Here is a build for x86_64/Linux/musl, @ErnestDong you can give it a test.

@ErnestDong
Copy link

It works. Thank you. Happy new year

@SteveLauC SteveLauC merged commit 15f4ad7 into topgrade-rs:main Dec 30, 2023
7 checks passed
@SteveLauC SteveLauC deleted the pip branch May 25, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update pip3 when pip config has set global.break-system-packages
2 participants