File Shortcut & Horizontal bar in locked mode #132

Logic-gate · 2016-08-26T11:30:12Z

fixes issues #91 and #40

As stated in issue toptal#40; ctrl + n creates a new browser window rather than a new file. New shortcut ctlr + alt + n.

As stated in issue toptal#91, the scroll bar(horizontal) appears when in locked mode. The suggested fix does in fact work.

Highlight update

Shortcut keys for Save, New, and Duplicate now include alt

seejohnrun · 2016-09-19T13:37:52Z

I agree these are annoying - but maybe we can just change the shortcuts for the problematic browsers?

Logic-gate · 2016-09-19T17:21:02Z

Fair point, but the problematic browsers are the most popular. Chrome, Firefox, and Safari(Not Tested) and there derivatives(C & FF).

Someone needs to test this on Safari.

seejohnrun · 2016-09-19T17:21:52Z

Are they problematic because they conflict with save, new window, etc?

Logic-gate · 2016-09-19T17:25:17Z

Yes, Control + N for instance creates a new browser window rather than a new haste. Chromium, vivaldi, FF

Test the changes here https://ma.tc

seejohnrun · 2016-09-19T17:30:34Z

Cool - maybe on Mac computers we stick with Ctrl+N since there's no
conflict there?

On Mon, Sep 19, 2016 at 1:25 PM, Amer Almadani [email protected]
wrote:

Yes, Control + N for instance creates a new browser window rather than a
new haste.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#132 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAD9xblDoKZYA5FIBvVSC46M2fejGGWtks5qrsV-gaJpZM4Jt_Tc
.

Logic-gate · 2016-09-19T17:32:44Z

Do you have a mac? I can't test it.

seejohnrun · 2016-09-19T17:52:52Z

Yep I do - I decided on the original key combinations (which are natural
for a mac user), because I don't use a PC too often

On Mon, Sep 19, 2016 at 1:32 PM, Amer Almadani [email protected]
wrote:

Do you have a mac? I can't test it.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#132 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAD9xTZwyGerhVQRD6PjEotrQVD_236Wks5qrsc8gaJpZM4Jt_Tc
.

Logic-gate · 2016-09-22T20:09:46Z

Okay...took me awhile.

Now, before your head explodes from how bad it is written, keep in mind Python is my forte' I never understood JS...

Live test here https://ma.tc

EDIT: I tested it on Linux using a User-agent switcher, it does work.

seejohnrun

Cool thank you! I have some ideas here to simplify things a bit, but otherwise going well

seejohnrun · 2016-09-22T23:05:50Z

static/application.js

@@ -258,13 +258,31 @@ haste.prototype.lockDocument = function() {

 haste.prototype.configureButtons = function() {
  var _this = this;
+  var save_desc = "control + alt + s";


I think that instead of having each be a separate case, we could introduce a variable called something like includeAlt which is a boolean, and then have two functions:

isShortcutFor(evt, keyCode) which basically is (!includeAlt || evt.ctrlKey) && evt.keyCode === keyCode)

and another that's like shortcutDescFor(letter) which puts together the string based on includeAlt like: 'control + ' + (includeAlt ? 'control + ' : '') + ' + ' + letter

This would tighten up your code and make this much more readable

seejohnrun · 2016-09-22T23:06:07Z

static/application.js

+
+
+/* navigator.appVersion.indexOf("Mac")!=-1; */
+  if (navigator.appVersion.indexOf("Mac")!=-1) {


this is includeAlt

seejohnrun · 2016-09-22T23:06:13Z

static/application.js

+/* navigator.appVersion.indexOf("Mac")!=-1; */
+  if (navigator.appVersion.indexOf("Mac")!=-1) {
+  save_desc = "control + s";
+  save_shortcut = function(evt) {return evt.ctrlKey && (evt.keyCode === 83)};


would remove this duplication

seejohnrun · 2016-09-22T23:06:26Z

static/application.js

@@ -276,9 +294,9 @@ haste.prototype.configureButtons = function() {
      $where: $('#box2 .new'),
      label: 'New',
      shortcut: function(evt) {
-        return evt.ctrlKey && evt.keyCode === 78  
+	     return new_shortcut(evt);


spacing is off here (spaces over tabs)

In the original version `duplicate` called `_this.doc.locked`. this was removed. Is this really necessary?? Also please test `control + n` on Mac. FF kept opening a new window

Logic-gate · 2016-10-01T11:58:13Z

Sorry it took awhile, was a bit busy. Applied the changes you requested, within the boundaries of my JS knowledge.

Live version at ma.tc

seejohnrun

very good, much clearer - a few quick comments (and thank you!)

seejohnrun · 2016-10-01T16:17:29Z

static/application.css

@@ -38,7 +38,6 @@ textarea {
 #box {
 	padding: 0px;
 	margin: 0px;
-	width: 100%;


I think I may have fixed this with #135 but don't know for sure

Nope #135 not fix issue

seejohnrun · 2016-10-01T16:17:36Z

static/application.js

@@ -256,15 +256,28 @@ haste.prototype.lockDocument = function() {
  });
 };

+


Extra newline

seejohnrun · 2016-10-01T16:18:05Z

static/application.js

 haste.prototype.configureButtons = function() {
  var _this = this;
+
+  var includeAlt = navigator.appVersion.indexOf("Mac")!=-1;


good here to use !== -1 for clarity

seejohnrun · 2016-10-01T16:18:15Z

static/application.js

+
+  function isShortcutFor(evt, keycode) {
+    return includeAlt ? evt.ctrlKey && evt.keyCode === keycode : evt.ctrlKey && evt.altKey && evt.keyCode === keycode
+


Extra newline here

seejohnrun · 2016-10-01T16:18:29Z

static/application.js

+  var includeAlt = navigator.appVersion.indexOf("Mac")!=-1;
+
+  function isShortcutFor(evt, keycode) {
+    return includeAlt ? evt.ctrlKey && evt.keyCode === keycode : evt.ctrlKey && evt.altKey && evt.keyCode === keycode


missing semicolons

seejohnrun · 2016-10-01T16:19:23Z

static/application.js

+  var includeAlt = navigator.appVersion.indexOf("Mac")!=-1;
+
+  function isShortcutFor(evt, keycode) {
+    return includeAlt ? evt.ctrlKey && evt.keyCode === keycode : evt.ctrlKey && evt.altKey && evt.keyCode === keycode


A lot of this is duplicative, may be easier to write like:

evt.ctrlKey && evt.keyCode === keyCode && (!includeAlt || evt.altKey)

Ahhh...I was looking for this. Thanks. Still cant get my head around JS

I am assuming that the latter part is some kind of nested statement, (!condition || if false). I can't seem to test this using the user agent switcher. Could you please test it on ma.tc. It does it does work with 'alt'. I just need confirmation before the I commit.

I think it may be due to the capitalization of keyCode if you didn't catch that - needs to match between the function param and the use (my code didn't)

I did catch it. I think should it work. Because it does catch the non mac condition and assigns altKey. I cant test it though.

Cool - if you push your code I can take a look

seejohnrun · 2016-10-01T16:19:47Z

static/application.js

@@ -298,7 +311,7 @@ haste.prototype.configureButtons = function() {
      $where: $('#box2 .raw'),
      label: 'Just Text',
      shortcut: function(evt) {
-        return evt.ctrlKey && evt.shiftKey && evt.keyCode === 82;
+      return evt.ctrlKey && evt.shiftKey && evt.keyCode === 82;


Better to keep these indentations, right?

Logic-gate · 2016-10-01T16:21:18Z

Sure, will get right on it.

did not take into account the format for a singular addon

Heroku testing

opted for file type due to ease...~lazy~

github-actions · 2022-03-08T14:47:47Z

This PR is stale because it has been open for 30 days with no activity.

github-actions · 2022-03-23T02:07:26Z

This PR was closed because it has been inactive for 14 days since being marked as stale.

Logic-gate added 5 commits August 26, 2016 14:19

New file shortcut

ec3b422

As stated in issue toptal#40; ctrl + n creates a new browser window rather than a new file. New shortcut ctlr + alt + n.

Locked view scroll bar

09bc5a5

As stated in issue toptal#91, the scroll bar(horizontal) appears when in locked mode. The suggested fix does in fact work.

Merge pull request #1 from seejohnrun/master

d861934

Highlight update

Shortcut keys update

3fb9caa

Shortcut keys for Save, New, and Duplicate now include alt

Shortcut keys update

0ed8633

Logic-gate added 2 commits September 22, 2016 23:07

Changed Shortcut scheme for Mac

baea36a

Changed Shortcut scheme for Mac

d494833

seejohnrun suggested changes Sep 22, 2016

View reviewed changes

Logic-gate added 2 commits October 1, 2016 14:55

Applied requested changes

a884e09

In the original version `duplicate` called `_this.doc.locked`. this was removed. Is this really necessary?? Also please test `control + n` on Mac. FF kept opening a new window

Applied Requested changes

9b06b00

seejohnrun suggested changes Oct 1, 2016

View reviewed changes

Logic-gate added 9 commits October 7, 2016 16:52

Updated to reflect changes request

e8dda0b

Updated to reflect changes request

3cc5bb1

Heroku app.json

d48f5c3

repo change

a052509

npm engine downgrade - h test

e7b161d

engine

92738a8

redis-addon

ae7bcb7

json format fix--duh

a897f4e

addon format change

d2c2d3f

did not take into account the format for a singular addon

Logic-gate added 2 commits May 31, 2017 00:34

changed to file type

9e7e999

Heroku testing

Removed redis

b6ef622

opted for file type due to ease...~lazy~

MAGICCC mentioned this pull request Jun 10, 2018

In locked haste appears horizontal scroll bar in browser #91

Closed

github-actions bot added the stale label Mar 8, 2022

github-actions bot closed this Mar 23, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

File Shortcut & Horizontal bar in locked mode #132

File Shortcut & Horizontal bar in locked mode #132

Logic-gate commented Aug 26, 2016

seejohnrun commented Sep 19, 2016

Logic-gate commented Sep 19, 2016

seejohnrun commented Sep 19, 2016

Logic-gate commented Sep 19, 2016 •

edited

Loading

seejohnrun commented Sep 19, 2016

Logic-gate commented Sep 19, 2016

seejohnrun commented Sep 19, 2016

Logic-gate commented Sep 22, 2016 •

edited

Loading

seejohnrun left a comment

seejohnrun Sep 22, 2016

seejohnrun Sep 22, 2016

seejohnrun Sep 22, 2016

seejohnrun Sep 22, 2016

Logic-gate commented Oct 1, 2016 •

edited

Loading

seejohnrun left a comment

seejohnrun Oct 1, 2016

ogarcia Jun 21, 2017

seejohnrun Oct 1, 2016

seejohnrun Oct 1, 2016

seejohnrun Oct 1, 2016

seejohnrun Oct 1, 2016

seejohnrun Oct 1, 2016

Logic-gate Oct 1, 2016

Logic-gate Oct 1, 2016 •

edited

Loading

seejohnrun Oct 1, 2016

Logic-gate Oct 2, 2016

seejohnrun Oct 3, 2016

seejohnrun Oct 1, 2016

Logic-gate commented Oct 1, 2016

github-actions bot commented Mar 8, 2022

github-actions bot commented Mar 23, 2022



		/* navigator.appVersion.indexOf("Mac")!=-1; */
		if (navigator.appVersion.indexOf("Mac")!=-1) {

		@@ -256,15 +256,28 @@ haste.prototype.lockDocument = function() {
		});
		};


		function isShortcutFor(evt, keycode) {
		return includeAlt ? evt.ctrlKey && evt.keyCode === keycode : evt.ctrlKey && evt.altKey && evt.keyCode === keycode

File Shortcut & Horizontal bar in locked mode #132

File Shortcut & Horizontal bar in locked mode #132

Conversation

Logic-gate commented Aug 26, 2016

seejohnrun commented Sep 19, 2016

Logic-gate commented Sep 19, 2016

seejohnrun commented Sep 19, 2016

Logic-gate commented Sep 19, 2016 • edited Loading

seejohnrun commented Sep 19, 2016

Logic-gate commented Sep 19, 2016

seejohnrun commented Sep 19, 2016

Logic-gate commented Sep 22, 2016 • edited Loading

seejohnrun left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Logic-gate commented Oct 1, 2016 • edited Loading

seejohnrun left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Logic-gate Oct 1, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Logic-gate commented Oct 1, 2016

github-actions bot commented Mar 8, 2022

github-actions bot commented Mar 23, 2022

Logic-gate commented Sep 19, 2016 •

edited

Loading

Logic-gate commented Sep 22, 2016 •

edited

Loading

Logic-gate commented Oct 1, 2016 •

edited

Loading

Logic-gate Oct 1, 2016 •

edited

Loading