Don't focus on video unless you've just given consent, sort focus sta…

…te, fix cookie in safari
torchbox · Mar 27, 2024 · 7988473 · 7988473
1 parent ecb7600
commit 7988473
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/tbx/static_src/javascript/components/youtube-embed.js b/tbx/static_src/javascript/components/youtube-embed.js
@@ -37,22 +37,20 @@ class YouTubeConsentManager {
     loadYouTubeEmbed() {
         // Hide the video placeholder and show the YouTube embed container
         this.youtubeEmbedNode.classList.add('loaded');
-        this.embedContainer.setAttribute('tabindex', '1');
-        this.embedContainer.focus();
     }
 
     handleconsentClick() {
         if (this.dontAskAgainCheckbox.checked) {
             this.handleDontAskAgainClick();
         }
         this.loadYouTubeEmbed();
+        this.embedContainer.querySelector('button').focus();
     }
 
     handleDontAskAgainClick() {
         // Set a cookie to remember the user's choice not to ask again
         Cookies.set('youtube_consent', 'true', {
-            expires: 7,
-            secure: true,
+            expires: 365,
             sameSite: 'Lax',
         });
 

diff --git a/tbx/static_src/sass/components/_youtube-embed.scss b/tbx/static_src/sass/components/_youtube-embed.scss
@@ -148,5 +148,10 @@
         @media (scripting: none) {
             display: block;
         }
+
+        button:focus {
+            @include focus-style();
+            outline-offset: -2px;
+        }
     }
 }