Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Youtube consent - front-end #183

Merged
merged 4 commits into from
Mar 27, 2024

Conversation

helenb
Copy link
Member

@helenb helenb commented Mar 22, 2024

Link to Ticket

Description of Changes Made

  • As requested by Ben, use a checkbox to remember preferences for the future, rather than a button
  • Tidy up JS
  • Styling
  • Fallback if the thumbnail is not fetched
  • Make buttons transparent by default (Ben request)

How to Test

This page has a video you can test on: http://localhost:8000/blog/charity-seo-what-you-need-to-know-right-now/
Pattern library (without consent behaviour): http://localhost:8000/pattern-library/pattern/patterns/molecules/streamfield/blocks/embed_block.html

Screenshots

Expand to see more Screenshot 2024-03-22 at 12 23 58

MR Checklist

  • Add a description of your pull request and instructions for the reviewer to verify your work.
  • If your pull request is for a specific ticket, link to it in the description.
  • Stay on point and keep it small so the merge request can be easily reviewed.
  • Tests and linting passes.

Unit tests

  • Added
  • Not required

Documentation

Browser testing

  • I have tested in the following browsers and environments (edit the list as required)
    • Latest version of Chrome on mac
    • Latest version of Firefox on mac
    • Latest version of Safari on mac
    • Safari on last two versions of iOS
    • Chrome on last two versions of Android
  • Not required

Data protection

  • Not relevant
  • This adds new sources of PII and documents it and modifies Birdbath processors accordingly

Accessibility

  • Automated WCAG 2.1 tests pass
  • HTML validation passes
  • Manual WCAG 2.1 tests completed
  • I have tested in a screen reader
  • I have tested in high-contrast mode
  • Any animations removed for prefers-reduced-motion
  • Not required

Sustainability

  • Images are optimised and lazy-loading used where appropriate
  • SVGs have been optimised
  • Perfomance and transfer of data considered
  • If JavaScript is needed alternatives have been considered
  • Not required

Pattern library

  • The pattern library component for this template displays correctly, and does not break parent templates
  • The styleguide is updated if relevant
  • Changes are not relevant the pattern library

@helenb helenb marked this pull request as draft March 22, 2024 12:10
@helenb helenb marked this pull request as ready for review March 22, 2024 13:21
@helenb helenb requested a review from chris-lawton March 22, 2024 13:22
@helenb helenb force-pushed the feature/privacy-focused-youtube-embeds-front-end-styling branch from d1baa2f to aeb63cd Compare March 22, 2024 13:25
Copy link
Member

@chris-lawton chris-lawton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Helen, the code all looks good to me and working as expected locally.

I'm sure it's been through a discussion with Ben but it wasn't immediately obvious to me that it's a video - I think it's the lack of big red play button. Might just be me though not being used to it : )

@helenb
Copy link
Member Author

helenb commented Mar 22, 2024

Thanks Helen, the code all looks good to me and working as expected locally.

I'm sure it's been through a discussion with Ben but it wasn't immediately obvious to me that it's a video - I think it's the lack of big red play button. Might just be me though not being used to it : )

Thanks @chris-lawton - useful feedback. I'll get it on staging for Ben to consider.

@helenb helenb force-pushed the feature/privacy-focused-youtube-embeds-front-end-styling branch from aeb63cd to c590912 Compare March 22, 2024 14:46
@helenb helenb self-assigned this Mar 26, 2024
@helenb helenb force-pushed the feature/privacy-focused-youtube-embeds-front-end-styling branch from c590912 to d953146 Compare March 27, 2024 15:14
@helenb helenb merged commit 87de571 into main Mar 27, 2024
6 checks passed
@helenb helenb deleted the feature/privacy-focused-youtube-embeds-front-end-styling branch March 27, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants