Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add authors to impact report #206

Merged
merged 3 commits into from
Apr 12, 2024
Merged

Add authors to impact report #206

merged 3 commits into from
Apr 12, 2024

Conversation

helenb
Copy link
Member

@helenb helenb commented Apr 11, 2024 •
edited
Loading

Link to Ticket

Description of Changes Made

I realised I had forgotten to style the author(s) for the impact report

  • Re-uses the work-page-authors component, but renames it as it is now used on more than one page
  • Adjusts the grid position of the authors for the impact report page
  • Adds the same @cached_property as on the work page model to fetch the first author

How to Test

You can test in the pattern library: http://localhost:8000/impact-report-2023/

Screenshots

Expand to see more Screenshot 2024-04-11 at 20 30 00

MR Checklist

  • Add a description of your pull request and instructions for the reviewer to verify your work.
  • If your pull request is for a specific ticket, link to it in the description.
  • Stay on point and keep it small so the merge request can be easily reviewed.
  • Tests and linting passes.

Unit tests

  • Added
  • Not required

Documentation

Browser testing

  • I have tested in the following browsers and environments (edit the list as required)
    • Latest version of Chrome on mac
  • Not required

Data protection

  • Not relevant
  • This adds new sources of PII and documents it and modifies Birdbath processors accordingly

Accessibility

  • Automated WCAG 2.1 tests pass
  • HTML validation passes
  • Manual WCAG 2.1 tests completed
  • I have tested in a screen reader
  • I have tested in high-contrast mode
  • Any animations removed for prefers-reduced-motion
  • Not required

Sustainability

  • Images are optimised and lazy-loading used where appropriate
  • SVGs have been optimised
  • Perfomance and transfer of data considered
  • If JavaScript is needed alternatives have been considered
  • Not required

Pattern library

  • The pattern library component for this template displays correctly, and does not break parent templates
  • The styleguide is updated if relevant
  • Changes are not relevant the pattern library

@helenb helenb changed the base branch from main to integration/impact-report April 11, 2024 19:34
@helenb helenb marked this pull request as draft April 11, 2024 19:34
@helenb helenb self-assigned this Apr 11, 2024
engineervix
engineervix approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@engineervix engineervix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BE changes LGTM 👍

@helenb helenb marked this pull request as ready for review April 12, 2024 10:55
@helenb helenb merged commit e61fe45 into integration/impact-report Apr 12, 2024
4 checks passed
@helenb helenb deleted the fix/add-authors-to-impact-report branch April 12, 2024 10:56
helenb added a commit that referenced this pull request Apr 15, 2024
@helenb
Add authors to impact report (#206)
43958da 
* Add authors to the impact report, and rename the work-page-authors component now that it is used elsewhere

* Update the pattern library

* Catch another ref to work-page-authors
helenb added a commit that referenced this pull request Apr 15, 2024
@engineervix @SharmaineLim @helenb
Integration - impact report (#195)
3e3b1e6 
* Copy pattern library config for impact report from current build

* add impact_reports app

this is copied from the current build

* Add template placeholders for impact reports

* We don't need impact_reports.ImpactReportAuthor because it's covered by torchbox.PageAuthor

* Add database migration

* Remove ParagraphWithQuoteBlock

* Remove TwoColumnTextGridBlock

* Remove ThreeColumnImageGridBlock

* Remove ParagraphWithImageBlock

* Use tbx.core.utils.fields.StreamField on ImpactReportPage

* WIP: FE | Impact Report page styles (#197)

* Rename instagram gallery block for consistency

* Set up impact report page with dummy blocks

* Add template class to homepage

* Style impact report heading block

* Remove impact report blocks that no longer exist from the impact report pattern library page

* Update instagram block template path

* Add instagram gallery markup and styling

* Updates to impact report page fields to be in line with design

* Don't lazy load the work page image as it is too near the top

* Update template fields and display the main image

* page heading area and anchor links

* Update impact report main image to match the work page one

* make the navigation sticky at desktop

* further updates to the impact report model to add the common page mixins

* isort

* Correct anchor landing position and make nav sticky at mobile

* Styling for small image with text

* accessibility fixes

* Make sure everything works in the pattern library and update the styleguide

* fix class names

* Make the impact report heading image a required field

* Update docs

* don't animate arrow in nav for prefers reduced motion

* typo fix

* squash migrations and code review feedback

---------

Co-authored-by: Helen C <[email protected]>

* Add authors to impact report (#206)

* Add authors to the impact report, and rename the work-page-authors component now that it is used elsewhere

* Update the pattern library

* Catch another ref to work-page-authors

* Update yaml to remove saturation-0.6

---------

Co-authored-by: Sharmaine Lim <[email protected]>
Co-authored-by: Helen C <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siimonevans siimonevans siimonevans approved these changes

@engineervix engineervix engineervix approved these changes

Assignees

@helenb helenb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@helenb @siimonevans @engineervix