Skip to content

Commit

Permalink
fix(react-query): remove peerDeps error when installing @suspensive/r…
Browse files Browse the repository at this point in the history
…eact-query (#1434)

# Overview

<!--
    A clear and concise description of what this pr is about.
 -->

remove below peerDeps error
We want to premote @suspensive/react-query & prevent installing
@suspensive/react-query-*.

```shell
➤ YN0000: ┌ Post-resolution validation
➤ YN0060: │ @tanstack/react-query is listed by your project with version 4.0.10 (p8ab5e), which doesn't satisfy what @suspensive/react-query-5 (via @suspensive/react-query) and other dependencies request (but they have non-overlapping ranges!).
```

And I want to prevent one way to alias like below

```json
{
  "dependencies": {
    "@suspensive/react": "^2.18.12",
    "@suspensive/react-query": "npm:@suspensive/react-query-4@^2.18.12",
  }
}
```

We want to make users just use like below

```json
{
  "dependencies": {
    "@suspensive/react": "^3.0.0",
    "@suspensive/react-query": "^3.0.0",
  }
}
```

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md)
2. I added documents and tests.
  • Loading branch information
manudeli authored Feb 16, 2025
1 parent c98b1ca commit 2be4348
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 12 deletions.
7 changes: 7 additions & 0 deletions .changeset/chilly-mugs-press.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'@suspensive/react-query-4': patch
'@suspensive/react-query-5': patch
'@suspensive/react-query': patch
---

remove peerDeps error
7 changes: 1 addition & 6 deletions packages/react-query-4/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -58,14 +58,9 @@
"react": "catalog:react19"
},
"peerDependencies": {
"@tanstack/react-query": "^4",
"@tanstack/react-query": "*",
"react": "^18 || ^19"
},
"peerDependenciesMeta": {
"@tanstack/react-query": {
"optional": true
}
},
"publishConfig": {
"access": "public"
}
Expand Down
7 changes: 1 addition & 6 deletions packages/react-query-5/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -58,14 +58,9 @@
"react": "catalog:react19"
},
"peerDependencies": {
"@tanstack/react-query": "^5",
"@tanstack/react-query": "*",
"react": "^18 || ^19"
},
"peerDependenciesMeta": {
"@tanstack/react-query": {
"optional": true
}
},
"publishConfig": {
"access": "public"
}
Expand Down

0 comments on commit 2be4348

Please sign in to comment.