Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-query): remove tsd #553

Merged
merged 3 commits into from
Jan 4, 2024
Merged

fix(react-query): remove tsd #553

merged 3 commits into from
Jan 4, 2024

Conversation

manudeli
Copy link
Member

@manudeli manudeli commented Jan 4, 2024

fix #545

Overview

I remove unnecessary tsd to replace it by vitest

PR Checklist

  • I did below actions if need
  1. I read the Contributing Guide
  2. I added documents and tests.

Copy link

vercel bot commented Jan 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v1 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 4, 2024 2:56pm
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 4, 2024 2:56pm
visualization ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 4, 2024 2:56pm

@manudeli manudeli self-assigned this Jan 4, 2024
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 4, 2024 14:32 Inactive
@manudeli manudeli marked this pull request as ready for review January 4, 2024 14:33
Copy link

codesandbox-ci bot commented Jan 4, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Merging #553 (f0ba0e1) into main (28a005c) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #553   +/-   ##
=======================================
  Coverage   84.33%   84.33%           
=======================================
  Files          29       29           
  Lines         466      466           
  Branches      108      108           
=======================================
  Hits          393      393           
  Misses         63       63           
  Partials       10       10           
Components Coverage Δ
@suspensive/react 100.00% <ø> (ø)
@suspensive/react-query 0.00% <ø> (ø)
@suspensive/react-await 100.00% <ø> (ø)
@suspensive/react-image 24.00% <ø> (ø)

@vercel vercel bot temporarily deployed to Preview – visualization January 4, 2024 14:33 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v1 January 4, 2024 14:34 Inactive
Copy link

changeset-bot bot commented Jan 4, 2024

⚠️ No Changeset found

Latest commit: f0ba0e1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – docs-v1 January 4, 2024 14:54 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 4, 2024 14:55 Inactive
@vercel vercel bot temporarily deployed to Preview – visualization January 4, 2024 14:56 Inactive
Copy link
Member

@minsoo-web minsoo-web left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!! Lets Go!!

@minsoo-web minsoo-web merged commit c4807b1 into main Jan 4, 2024
17 checks passed
@minsoo-web minsoo-web deleted the react-query/fix/remove-tsd branch January 4, 2024 16:22
manudeli added a commit that referenced this pull request Aug 3, 2024
fix #545 

# Overview

<!--
    A clear and concise description of what this pr is about.
 -->

I remove unnecessary tsd to replace it by vitest

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/suspensive/react/blob/main/CONTRIBUTING.md)
2. I added documents and tests.
manudeli added a commit that referenced this pull request Aug 3, 2024
fix #545 

# Overview

<!--
    A clear and concise description of what this pr is about.
 -->

I remove unnecessary tsd to replace it by vitest

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/suspensive/react/blob/main/CONTRIBUTING.md)
2. I added documents and tests.
manudeli added a commit that referenced this pull request Aug 3, 2024
fix #545 

# Overview

<!--
    A clear and concise description of what this pr is about.
 -->

I remove unnecessary tsd to replace it by vitest

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/suspensive/react/blob/main/CONTRIBUTING.md)
2. I added documents and tests.
manudeli added a commit that referenced this pull request Aug 3, 2024
fix #545 

# Overview

<!--
    A clear and concise description of what this pr is about.
 -->

I remove unnecessary tsd to replace it by vitest

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/suspensive/react/blob/main/CONTRIBUTING.md)
2. I added documents and tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Remove tsd
2 participants