Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5 - Droid: InjectJavascriptAsync can return the result of a different call #9

Conversation

tossingc
Copy link
Owner

@tossingc tossingc commented Jan 18, 2019

  1. added sample page which tests this behavior
  2. [Droid] modified FormsWebViewRenderer to create a new instance of JavascriptValueCallback for each call to InjectJavascriptAsync
  3. revert previous hacky fix which synchronized every call to InjectJavascriptAsync (will cause performance issues)

fixes #5 (corresponding issue in SKLn-Rad repo is 116 - SKLn-Rad#116)

…lt of a different call

1. added sample page which tests this behavior
2. [Droid] modified FormsWebViewRenderer to create a new instance of JavascriptValueCallback for each call to InjectJavascriptAsync
@tossingc tossingc merged commit 6ca471f into master Jan 18, 2019
@tossingc tossingc self-assigned this Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Droid: InjectJavascriptAsync can return the result of a different call
1 participant