Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing bool serialization #32

Merged
merged 3 commits into from
Dec 6, 2017
Merged

fixing bool serialization #32

merged 3 commits into from
Dec 6, 2017

Conversation

1sarojkandel
Copy link

No description provided.

@coveralls
Copy link

coveralls commented Dec 4, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 88.394% when pulling 45fa0eb on 1sarojkandel:master into 5ef9277 on toumorokoshi:master.

@toumorokoshi
Copy link
Owner

@sarojkandel1 looks great! can we get some unit tests?

toumorokoshi
toumorokoshi requested changes Dec 5, 2017
View reviewed changes
Copy link
Owner

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we could get some unit tests, that would be great!

@coveralls
Copy link

coveralls commented Dec 5, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 88.394% when pulling 139c73f on 1sarojkandel:master into 5ef9277 on toumorokoshi:master.

@coveralls
Copy link

coveralls commented Dec 5, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 88.394% when pulling 139c73f on 1sarojkandel:master into 5ef9277 on toumorokoshi:master.

@toumorokoshi
Copy link
Owner

Great, thanks!

@toumorokoshi toumorokoshi merged commit ac8e6c2 into toumorokoshi:master Dec 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toumorokoshi toumorokoshi toumorokoshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@1sarojkandel @coveralls @toumorokoshi @sarojkandel1