Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Migrate docs to PHP-based rendering #265

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

brotkrueml
Copy link
Contributor

The Documentation Team introduced the PHP-based rendering (guides) as replacement for the previously used Sphinx-based rendering (which is now deprecated).

This change migrates the configuration from Settings.cfg to guides.xml.

To generate the docs, a Composer script is introduced:

composer docs:generate

Additionally, a new GitHub Workflow has been added which checks, if there are warnings or errors on rendering of the documentation.

See: https://typo3.org/article/transition-to-full-php-based-rendering-for-all-typo3-extension-manuals

The Documentation Team introduced the PHP-based rendering (guides) as replacement for the
previously used Sphinx-based rendering (which is now deprecated).

This change migrates the configuration from Settings.cfg to guides.xml.

To generate the docs, a Composer script is introduced:

    composer docs:generate

Additionally, a new GitHub Workflow has been added which checks, if there are warnings or errors
on rendering of the documentation.

See: https://typo3.org/article/transition-to-full-php-based-rendering-for-all-typo3-extension-manuals
@brotkrueml
Copy link
Contributor Author

brotkrueml commented Dec 4, 2024

Please rerun the new Documentation workflow. I had that error locally also the first time, but haven't spot an error. All additional runs doesn't reveal that error.

@christianbltr
Copy link
Member

Thanks for the PR! Unfortunately re-running the Documentation workflow doesn't help, it's still failing.

@brotkrueml
Copy link
Contributor Author

Thanks for the PR! Unfortunately re-running the Documentation workflow doesn't help, it's still failing.

Okay, thanks. Will have a look again. Strangely, worked on my machine(TM) after restart (and also when throwing away the generated folder).

@christianbltr christianbltr merged commit 1ee7040 into tpwd:master Jan 3, 2025
5 of 6 checks passed
christianbltr added a commit that referenced this pull request Jan 3, 2025
Add "fail-on-log" and "no-progress"
options to better match the local
rendering of the documentation
with the test in the GitHub pipeline.
That allows to find rendering issues
locally, not only during the pipeline
run.
see #265
@christianbltr
Copy link
Member

This is now fixed.

FYI: By adding the "fail-on-log" and "no-progress" options (93ef7c6) the local rendering process threw the same error as the GitHub pipeline (it was an indentation issue: f6756fa) which allowed local debugging.

@brotkrueml brotkrueml deleted the migrate-docs-to-guides branch January 3, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants