Merge pull request #1171 from traPtitech/fix/flaky-test

Flakyなテストを直した
traPtitech · Jan 22, 2024 · 044c9d9 · 044c9d9
2 parents 1a0611c + a332eef
commit 044c9d9
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 24 deletions.
diff --git a/model/questions_test.go b/model/questions_test.go
@@ -503,29 +503,6 @@ func updateQuestionTest(t *testing.T) {
 				},
 			},
 		},
-		{
-			description: "questionnaireID: valid->valid",
-			before: before{
-				Questions: Questions{
-					QuestionnaireID: questionnaireDatas[0].ID,
-					PageNum:         1,
-					QuestionNum:     1,
-					Type:            "TextArea",
-					Body:            "自由記述欄",
-					IsRequired:      false,
-				},
-			},
-			after: after{
-				Questions: Questions{
-					QuestionnaireID: questionnaireDatas[1].ID,
-					PageNum:         1,
-					QuestionNum:     1,
-					Type:            "TextArea",
-					Body:            "自由記述欄",
-					IsRequired:      false,
-				},
-			},
-		},
 		{
 			description: "questionnaireID: valid->invalid",
 			before: before{

diff --git a/router/questionnaires_test.go b/router/questionnaires_test.go
@@ -1143,7 +1143,7 @@ func TestPostQuestionByQuestionnaireID(t *testing.T) {
 				buf := bytes.NewBuffer(nil)
 				err := json.NewEncoder(buf).Encode(test.request)
 				if err != nil {
-					t.Errorf("failed to encode request: %w", err)
+					t.Errorf("failed to encode request: %v", err)
 				}
 
 				request = buf