Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for restricting duplicate responses #1278

Merged
merged 8 commits into from
Jan 6, 2025

Conversation

Eraxyso
Copy link

@Eraxyso Eraxyso commented Nov 2, 2024

This PR migrates the changes from #1155 to the latest implementation and resolves several issues related to the newly introduced parameters.

@kaitoyama kaitoyama requested a review from Copilot December 6, 2024 04:59

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 19 changed files in this pull request and generated no suggestions.

Files not reviewed (14)
  • docs/swagger/swagger.yaml: Language not supported
  • model/questionnaires_impl.go: Evaluated as low risk
  • model/errors.go: Evaluated as low risk
  • controller/adapter.go: Evaluated as low risk
  • model/targets_test.go: Evaluated as low risk
  • model/responses_test.go: Evaluated as low risk
  • model/validations_test.go: Evaluated as low risk
  • model/scale_labels_test.go: Evaluated as low risk
  • openapi/spec.go: Evaluated as low risk
  • model/questionnaires.go: Evaluated as low risk
  • router/questionnaires.go: Evaluated as low risk
  • controller/questionnaire.go: Evaluated as low risk
  • router/questionnaires_test.go: Evaluated as low risk
  • model/v3.go: Evaluated as low risk
Comments skipped due to low confidence (1)

openapi/types.go:158

  • [nitpick] The variable name IsDuplicateAnswerAllowed is inconsistent with the previous naming convention IsAllowingMultipleResponses. Consider renaming it to IsAllowingMultipleResponses for consistency.
IsDuplicateAnswerAllowed bool `json:"is_duplicate_answer_allowed"`
@Eraxyso Eraxyso merged commit 1d982df into fix/openapi Jan 6, 2025
4 of 7 checks passed
@Eraxyso Eraxyso deleted the fix/openapi-duplicate_response branch January 6, 2025 00:35
@Eraxyso Eraxyso mentioned this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants