Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ベンチマーク周りの OpenAPI を改善 #27

Merged
merged 6 commits into from
Jan 10, 2025
Merged

ベンチマーク周りの OpenAPI を改善 #27

merged 6 commits into from
Jan 10, 2025

Conversation

cp-20
Copy link
Contributor

@cp-20 cp-20 commented Jan 9, 2025 •
edited
Loading

  • Benchmark ->BenchmarkListItem
  • BenchmarkResult -> Benchmark

status ごとに返ってくるものが違うので、oneOf で分岐した

@cp-20 cp-20 requested a review from ikura-hamu January 9, 2025 07:07
@cp-20 cp-20 mentioned this pull request Jan 9, 2025
Merged
@cp-20 cp-20 changed the title ベンチマークの詳細を返すところで socre, startedAt, finishedAt を optional に ベンチマーク周りの OpenAPI を改善 Jan 9, 2025
@ikura-hamu
Copy link
Member

なんかGoのコード生成したら落ちた。あとでちょっといろいろ調べるので待ってください

@cp-20 cp-20 merged commit 6840f5d into main Jan 10, 2025
9 checks passed
@cp-20 cp-20 deleted the openapi/fix-benchmark-result branch January 10, 2025 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikura-hamu ikura-hamu ikura-hamu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cp-20 @ikura-hamu