Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ベンチマークの結果(passed/failed)をレスポンスに含める #28

Merged
merged 7 commits into from
Jan 12, 2025
Merged

ベンチマークの結果(passed/failed)をレスポンスに含める #28

merged 7 commits into from
Jan 12, 2025

Conversation

ikura-hamu
Copy link
Member

  • ✨ FinishedBenchmarkにresultを追加
  • 🩹 Goのコード生成
  • 🚧 フロントエンドのコード生成

@ikura-hamu ikura-hamu requested a review from a team January 10, 2025 06:45
@ikura-hamu
Copy link
Member Author

かなりもやもやするやり方だけどしょうがないか。
package.jsonのスクリプトで&&でつなげるよりかは、openapi-gen.tsで全部書いちゃった方がきれいそうなのでやっておきます。
https://openapi-ts.dev/node#node-js-api

@ikura-hamu
Copy link
Member Author

やっておきますというか、やってもいいものですか

@cp-20
Copy link
Contributor

cp-20 commented Jan 12, 2025

お願いします:pray:

@ikura-hamu
Copy link
Member Author

ikura-hamu commented Jan 12, 2025 •
edited
Loading 

/**
 * This file was auto-generated by openapi-typescript.
 * Do not make direct changes to the file.
 */

これCLIからやろうとするとこのコメント消えちゃうな。
自分で書けばいいのか

@ikura-hamu ikura-hamu marked this pull request as ready for review January 12, 2025 05:54
@ikura-hamu ikura-hamu merged commit 2257d97 into main Jan 12, 2025
9 checks passed
@ikura-hamu ikura-hamu deleted the openapi_bench_result branch January 12, 2025 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cp-20 cp-20 cp-20 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ikura-hamu @cp-20