gRPCのスキーマ定義 #31
Merged
gRPCのスキーマ定義 #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 7 out of 11 changed files in this pull request and generated no comments.
Files not reviewed (4)
- go.mod: Language not supported
- README.md: Evaluated as low risk
- Taskfile.yml: Evaluated as low risk
- proto/portal/v1/benchmark.proto: Evaluated as low risk
|
The latest Buf updates on your PR. Results from workflow Protobuf CI / buf (pull_request).
|
|
breakingが落ちてるのはそれはそうなので、無視してください。これがマージされたらrulesetに追加します。 |
pirosiki197
reviewed
Jan 12, 2025
pirosiki197
reviewed
Jan 13, 2025
|
|
||
| message BenchmarkJob { | ||
| string benchmark_id = 1; | ||
| string target_url = 2; |
There was a problem hiding this comment.
isuconだとurlよりipアドレスでベンチマーク対象を決めるイメージがあるのですが、urlにしている理由はありますか？
There was a problem hiding this comment.
URLにしておけば、IPアドレス以外にしたくなったとき（無いと思うけど）も対応できるな～と思ったぐらいで、特に深い意味はないです
pirosiki197
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
protobuf関係のCIは別で結局入れた。