move credentials to Secret

[tamcore]

This touches on my comment in #27 (comment), as ConfigMaps are not intended to hold confidential data.

[tananaev]

@filippolmt would you mind taking a look.

[filippolmt]

@tananaev by adding this configuration in the xml file, is it possible to use environment variables?

[tamcore]

It's defined here https://github.com/traccar/traccar/blob/master/src/main/java/org/traccar/config/Config.java#L58-L59

[tananaev]

Yes.

[filippolmt]

As an improvement, I would add the possibility of using an existing secrets in the cluster (of course documenting how to do this) and adding a functionality test.

The fact remains that this PR is fine, you could opt to do it at a later date.

[tamcore]

I think that's already covered by env :)

traccar-helm/charts/traccar/values.yaml

Lines 170 to 184 in ae85446

	# This allows you to use environment variables (i.e. referenced from Secrets) to use in your configuration
	# The names of the keys are identical. But, a dot (.), you'll have to use an underscore (_) and define everything in UPPERCASE
	env: []
	# - name: "CONFIG_USE_ENVIRONMENT_VARIABLES"
	# value: "true"
	# - name: "DATABASE_USER"
	# valueFrom:
	# secretKeyRef:
	# name: "postgres-secrets"
	# key: "username"
	# - name: "DATABASE_PASSWORD"
	# valueFrom:
	# secretKeyRef:
	# name: "postgres-secrets"
	# key: "password"

[filippolmt]

Thank you, I had completely missed it. :)

[filippolmt]

@tananaev we can merge the PR

[tananaev]

Thanks