Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds helpful print commands for tracing and debugging the interp system. #1648

Merged
merged 4 commits into from
Jul 19, 2024

Conversation

rcoreilly
Copy link
Contributor

I found these basic functions and Stringer methods essential for tracking down issues fixed recently -- probably be of use to others and I couldn't find something else in the code that would provide similar utility, though I never tried the debugger.

Copy link
Member

@mvertes mvertes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for those text debugging functions. Their use is simple and straightforward. Definitely useful.

Just for info, up to now my debugging practice was to generate and display graphviz dot graphs for the AST and CFG, using the methods in interp/dot.go, and run something like:

YAEGI_DOT_CMD='dotty -' YAEGI_AST_CMD=1 go run ./cmd/yaegi

interp/trace.go Outdated Show resolved Hide resolved
interp/trace.go Outdated Show resolved Hide resolved
interp/trace.go Outdated Show resolved Hide resolved
@rcoreilly
Copy link
Contributor Author

Thanks for the fixes and the pointer to the graphviz options -- didn't notice those before.

Copy link
Member

@mvertes mvertes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvertes
Copy link
Member

mvertes commented Jul 19, 2024

@rcoreilly please update, so we can merge it. Thanks.

@mvertes mvertes added this to the v0.16.x milestone Jul 19, 2024
@traefiker traefiker merged commit b6315ca into traefik:master Jul 19, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants