Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Non-Boolean conditional pass #12

Draft
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

tob-joe
Copy link

@tob-joe tob-joe commented Dec 30, 2022

This includes:

  • An updated constant-propagation implementation that adds support for tracking uncertainty about the exact value (e.g. Boolean(None), which is definitely boolean but doesn't have a known exact value)
  • A new analysis that finds conditionals that expect boolean values but are being passed not-definitely-boolean values
  • The flake.nix that pulls in rust 1.65.0 for development

Things are a little sloppy and I have not tested the new features properly so I'm leaving it as a draft for now.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ fegge
❌ tob-joe
You have signed the CLA already but the status is still pending? Let us recheck it.

@tob-joe tob-joe requested a review from fegge December 30, 2022 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants