Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use uv for dependencies handling #31

Merged
merged 6 commits into from
Sep 25, 2024
Merged

Use uv for dependencies handling #31

merged 6 commits into from
Sep 25, 2024

Conversation

DarkaMaul
Copy link
Contributor

@DarkaMaul DarkaMaul commented Aug 22, 2024

Closes #30

This PR implements the following changes :

  • Recommends to install uv and use it to run cookiecutter using uvx
  • Uses uv venv to create the virtual env
  • Uses uvx to build the package using build.
  • Updates the ruff version
  • Restricts the ruff checks to only src/ and test/ folders
  • Update the GH Actions to run tests using uv too

Potential improvements :

  • Rename the default virtual env name to .env and use the environment auto detection feature from uv.

@DarkaMaul DarkaMaul requested a review from woodruffw August 22, 2024 15:27
@DarkaMaul
Copy link
Contributor Author

DarkaMaul commented Sep 3, 2024

Note to myself: not yet ready because workflows are not installing uv yet

Ready to review.

Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DarkaMaul, great work! Looks like this sped up the selftests by over 4x, which is pretty crazy.

@woodruffw woodruffw merged commit 0bdb2db into main Sep 25, 2024
4 checks passed
@woodruffw woodruffw deleted the dm/uv branch September 25, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to uv by default
2 participants