Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

abi: Memory class arguments. #465

Merged
merged 12 commits into from
Jan 10, 2024
Merged

abi: Memory class arguments. #465

merged 12 commits into from
Jan 10, 2024

Conversation

lkorenc
Copy link
Contributor

@lkorenc lkorenc commented Dec 12, 2023

Included are some fixes to void return type and empty argument lists.

@lkorenc lkorenc marked this pull request as ready for review January 9, 2024 11:42
@lkorenc lkorenc requested a review from xlauko as a code owner January 9, 2024 11:42
@lkorenc lkorenc requested a review from Jezurko January 10, 2024 12:26
@github-actions GitHub Actions
Copy link
Contributor

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-format reports: 5 file(s) not formatted
  • include/vast/ABI/ABI.hpp
  • include/vast/ABI/Classify.hpp
  • lib/vast/Conversion/ABI/EmitABI.cpp
  • lib/vast/Conversion/ABI/LowerABI.cpp
  • lib/vast/Conversion/Common/IRsToLLVM.cpp

Have any feedback or feature suggestions? Share it here.

@lkorenc lkorenc merged commit 65e5952 into master Jan 10, 2024
5 checks passed
@lkorenc lkorenc deleted the abi-memory branch January 10, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xlauko xlauko xlauko approved these changes

@Jezurko Jezurko Awaiting requested review from Jezurko

Assignees
No one assigned
Labels
abi conversion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lkorenc @xlauko