Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove core strlit #467

Merged
merged 7 commits into from
Dec 20, 2023
Merged

Remove core strlit #467

merged 7 commits into from
Dec 20, 2023

Conversation

Jezurko
Copy link
Collaborator

@Jezurko Jezurko commented Dec 13, 2023

Custom string literal is no longer required and is an unnecessary duplication of logic already provided by MLIR.

@Jezurko Jezurko requested a review from lkorenc December 13, 2023 14:36
@Jezurko Jezurko self-assigned this Dec 13, 2023
@Jezurko Jezurko mentioned this pull request Dec 15, 2023
Closed
@Jezurko Jezurko marked this pull request as ready for review December 15, 2023 16:56
@Jezurko Jezurko requested a review from xlauko as a code owner December 15, 2023 16:56
@Jezurko Jezurko linked an issue Dec 17, 2023 that may be closed by this pull request
[Bug]: String literals in MLIR are not as permissive as those in C #468
Closed
@github-actions GitHub Actions
Copy link
Contributor

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-format reports: 4 file(s) not formatted
  • include/vast/Conversion/TypeConverters/TypeConverter.hpp
  • include/vast/Dialect/Core/CoreAttributes.hpp
  • lib/vast/Conversion/Common/IRsToLLVM.cpp
  • lib/vast/Dialect/HighLevel/HighLevelOps.cpp

Have any feedback or feature suggestions? Share it here.

@Jezurko Jezurko merged commit 88902a1 into master Dec 20, 2023
4 checks passed
@Jezurko Jezurko deleted the remove-core-strlit branch December 20, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkorenc lkorenc lkorenc approved these changes

@xlauko xlauko Awaiting requested review from xlauko xlauko is a code owner

Assignees

@Jezurko Jezurko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: String literals in MLIR are not as permissive as those in C
2 participants
@Jezurko @lkorenc