Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add endpoint to get task types #192

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Conversation

gabrieltaets-tw
Copy link
Contributor

@gabrieltaets-tw gabrieltaets-tw commented Nov 16, 2023

Context

  • Added taskType and taskSubType parameters to management query endpoints.
  • Added /getTaskTypes endpoint to retrieve list of registered task types and sub-types

these params and endpoints can be used by ninjas.transferwise.com/tasks to improve engineer experience with server-side filtering when supported

Checklist

@gabrieltaets-tw gabrieltaets-tw requested a review from a team as a code owner November 16, 2023 15:36
Copy link

@Jarvvski Jarvvski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but needs AppEng approval

@wise-github-bot-app
Copy link

The approval(s) from Jarvvski do(es)n't fullfill the approvers requirements because:

  • The approver's cost centre, ENGREG, maps to the ENGINEERING business function. As the code that was changed is owned by PLATFORM, this approval won't satisfy our separation of duties check. We'll need an additional approval from someone in PLATFORM. This approval may still help satisfy other codeowner requirements.

@gabrieltaets-tw gabrieltaets-tw merged commit 91d0660 into master Dec 13, 2023
13 checks passed
@gabrieltaets-tw gabrieltaets-tw deleted the mgmt-query-task-type branch December 13, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants