CAA-2356: Cancel tasks implementation #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WiserSep
changed the title
WiserSep
changed the title
WiserSep
changed the title
WiserSep
changed the title
onukristo
requested changes
Feb 12, 2025
integration-tests/src/test/java/com/transferwise/tasks/testapp/TaskCancellationIntTest.java
Outdated
Show resolved
Hide resolved
tw-tasks-core/src/main/java/com/transferwise/tasks/ITasksService.java
Outdated
Show resolved
Hide resolved
tw-tasks-core/src/main/java/com/transferwise/tasks/TasksService.java
Outdated
Show resolved
Hide resolved
tw-tasks-core/src/main/java/com/transferwise/tasks/helpers/CoreMetricsTemplate.java
Outdated
Show resolved
Hide resolved
tw-tasks-core/src/main/java/com/transferwise/tasks/helpers/CoreMetricsTemplate.java
Outdated
Show resolved
Hide resolved
tw-tasks-core/src/main/java/com/transferwise/tasks/TasksService.java
Outdated
Show resolved
Hide resolved
onukristo
approved these changes
Feb 25, 2025
| @@ -534,4 +536,14 @@ protected static class MetricHandle { | |||
| private Meter meter; | |||
|
|
|||
| } | |||
|
|
|||
| public void registerTaskCancelled(String taskType) { | |||
| meterCache.counter(METRIC_TASKS_CANCELLED_COUNT, TagsSet.of(TAG_BUCKET_ID, resolveBucketId(null), TAG_TASK_TYPE, taskType)) | |||
There was a problem hiding this comment.
There is no need to add the bucket tag at all.
Different (by name) metrics can have different set of tags.
And in dashboards the graphs will be "hand made" anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR adds functionality that will enable Canceling tasks in WAITING status. The usage here is that you scheduled a task in the future, but do not require it run anymore. This will set a tasks status to CANCELLED and will not run.
Checklist