Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vendored Versioneer from 0.18 to 0.29 #112

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

m-aciek
Copy link
Contributor

@m-aciek m-aciek commented Oct 27, 2023

  • installed the new Versioneer (pip install -U versioneer or equivalent)
  • re-runned versioneer install --vendor in the local source tree, to replace transifex/_version.py
  • committed all changed files

As specified in the guide (no changes to configuration were required).

Refs #106.

m-aciek added a commit to python/python-docs-pl that referenced this pull request Oct 27, 2023
@n1k0sv
Copy link

n1k0sv commented Oct 30, 2023

I updated Makefile and added a new test target for python 3.12 with Django 4.2, and tests failed.

It looks like the issue is that the requests library is pinned to 2.22.0 in base.txt and it fails. Maybe we should pin to 2.* and let the environment pick the latest compatible version of the second major. What do you think?

@m-aciek
Copy link
Contributor Author

m-aciek commented Oct 30, 2023

I replaced "closes" keyword with "refs" not to close #106 with this PR merged.

It looks like the pins are used only in CI and for local development, so it should be fine to pin it to the latest requests version for reproducible CI. It's not a strong opinion though.

@n1k0sv
Copy link

n1k0sv commented Oct 31, 2023

@m-aciek You will need to sign (only once) the Transifex CLA before we can merge this PR, per our Contributing guidelines.

As soon as this happens, I can merge this PR. And thank you for contributing to this repo 🙏

@n1k0sv
Copy link

n1k0sv commented Nov 7, 2023

Hey @m-aciek, we have fixed the requests lib issue on devel branch. Can you please rebase?

Also did you manage to get the CLA signed?

@m-aciek
Copy link
Contributor Author

m-aciek commented Nov 9, 2023

Hey @nbasili, I've pushed the rebased changes. Also a few minutes ago I've sent the signed CLA.

@n1k0sv n1k0sv merged commit 1ea0add into transifex:devel Nov 10, 2023
8 checks passed
@m-aciek m-aciek deleted the versioneer-0-29 branch November 10, 2023 08:20
m-aciek added a commit to python/python-docs-pl that referenced this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants