Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#250 follow XDG standard for logging #251

Merged
merged 2 commits into from
Mar 26, 2024
Merged

#250 follow XDG standard for logging #251

merged 2 commits into from
Mar 26, 2024

Conversation

s-riesenberg
Copy link
Contributor

relates to: #250

@lhendrick-t10
Copy link
Collaborator

Hello again @sriesenberg-reply! Thanks for the contribution! I'm reviewing the PR now but if you could update the test at test/unit/awsume/awsumepy/lib/test_config_management.py::test_load_config_no_path that will get us one step closer to merging this change!

Thank you again for helping out with awsume!

@s-riesenberg
Copy link
Contributor Author

Adjusted the test. The issue was load_config (and with it migrate_to_xdg_base_directories) calls mkdirs 3 times instead of 2, due to the new logs directory.

@lhendrick-t10 lhendrick-t10 merged commit 1b8e9f4 into trek10inc:master Mar 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s-riesenberg @lhendrick-t10