Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CircularProgress component #966

Draft
wants to merge 6 commits into
base: v2
Choose a base branch
from
Draft

feat: CircularProgress component #966

wants to merge 6 commits into from

Conversation

cheton
Copy link
Member

@cheton cheton commented Jan 21, 2025

Copy link

codesandbox bot commented Jan 21, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

changeset-bot bot commented Jan 21, 2025

⚠️ No Changeset found

Latest commit: e52271c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cheton cheton added the 🏗️ work in progress Work in progress label Jan 21, 2025
Copy link

codesandbox-ci bot commented Jan 21, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@trendmicro-frontend-bot
Copy link
Contributor

trendmicro-frontend-bot commented Jan 21, 2025

Tonic UI Demo

On 2025-01-26 10:34:57 +0000, PR #966 (e52271c) was successfully deployed. You can view it at the following link:
https://trendmicro-frontend.github.io/tonic-ui-demo/react/pr-966/

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 57 lines in your changes missing coverage. Please review.

Project coverage is 78.38%. Comparing base (56f957c) to head (e52271c).
Report is 1 commits behind head on v2.

Files with missing lines Patch % Lines
packages/react/src/progress/styles.js 25.00% 27 Missing ⚠️
packages/react/src/progress/CircularProgress.js 37.50% 15 Missing ⚠️
packages/react/src/spinner/Spinner.js 12.50% 14 Missing ⚠️
packages/react/src/progress/LinearProgress.js 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v2     #966      +/-   ##
==========================================
- Coverage   78.66%   78.38%   -0.28%     
==========================================
  Files         404      404              
  Lines        6706     6749      +43     
==========================================
+ Hits         5275     5290      +15     
- Misses       1431     1459      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codecov bot commented Jan 21, 2025

Bundle Report

Changes will increase total bundle size by 13.05kB (0.46%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@tonic-ui/react-cjs 839.41kB 6.77kB (0.81%) ⬆️
@tonic-ui/react-esm 787.52kB 6.28kB (0.8%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants