Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][UPDATE] itm #51

Merged
merged 9 commits into from
Jun 21, 2024
Merged

[16.0][UPDATE] itm #51

merged 9 commits into from
Jun 21, 2024

Conversation

YuriyGural
Copy link

Fixes related to version 16.0, some improvements and bug fixes, tested on a real database.

Fixes related to version 16.0, some improvements and bug fixes, tested on a real database.
Bridge between HR and IT Infrastructure Management.
Based on the hr_maintenance module, the field owner has been replaced with employee_id and department_id.
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 62.22222% with 34 lines in your changes missing coverage. Please review.

Project coverage is 73.12%. Comparing base (5da9704) to head (d8f0f4e).

Current head d8f0f4e differs from pull request most recent head fb4f44b

Please upload reports for the commit fb4f44b to get more accurate results.

Files Patch % Lines
hr_itm/models/equipment.py 44.44% 15 Missing ⚠️
itm/models/service_ad.py 20.00% 8 Missing ⚠️
itm/models/equipment.py 61.11% 4 Missing and 3 partials ⚠️
itm/models/access.py 80.00% 1 Missing and 2 partials ⚠️
itm/models/equipment_component.py 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             16.0      #51      +/-   ##
==========================================
- Coverage   73.78%   73.12%   -0.67%     
==========================================
  Files          40       43       +3     
  Lines        1316     1358      +42     
  Branches      161      173      +12     
==========================================
+ Hits          971      993      +22     
- Misses        319      338      +19     
- Partials       26       27       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mtelahun mtelahun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution. I especially liked how you separated out some functionality into hr_itm. I have only one minor comment.

itm/models/equipment.py Outdated Show resolved Hide resolved
@mtelahun
Copy link
Contributor

pre-commit check is failing. Please fix that. Then we can merge.

@mtelahun
Copy link
Contributor

Odoo and OCB builds failing:

2024-06-20 06:02:26,947 254 INFO odoo odoo.addons.hr_itm.tests.test_equipment: Starting TestEquipment.test_equipment_assign_to ... 
2024-06-20 06:02:26,975 254 INFO odoo odoo.addons.hr_itm.tests.test_equipment: ====================================================================== 
2024-06-20 06:02:26,976 254 ERROR odoo odoo.addons.hr_itm.tests.test_equipment: ERROR: TestEquipment.test_equipment_assign_to
Traceback (most recent call last):
  File "/__w/trevi-misc/trevi-misc/hr_itm/tests/test_equipment.py", line 47, in test_equipment_assign_to
    today = fields.Date.context_today(self)
  File "/opt/odoo/odoo/fields.py", line 2079, in context_today
    tz_name = record._context.get('tz') or record.env.user.tz
AttributeError: 'TestEquipment' object has no attribute '_context'

@mtelahun
Copy link
Contributor

Also, the pre-commit test is failing. Please click the "Details" link to the right to get the test logs

@YuriyGural
Copy link
Author

YuriyGural commented Jun 20, 2024

Also, the pre-commit test is failing. Please click the "Details" link to the right to get the test logs

Looks good.

I figured out how to run the test module and installed gen-odoo-readme on my server.
This is my not favorite part. :)

@mtelahun mtelahun merged commit 85f3d38 into trevi-software:16.0 Jun 21, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants