-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][UPDATE] itm #51
Conversation
Fixes related to version 16.0, some improvements and bug fixes, tested on a real database.
Bridge between HR and IT Infrastructure Management. Based on the hr_maintenance module, the field owner has been replaced with employee_id and department_id.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 16.0 #51 +/- ##
==========================================
- Coverage 73.78% 73.12% -0.67%
==========================================
Files 40 43 +3
Lines 1316 1358 +42
Branches 161 173 +12
==========================================
+ Hits 971 993 +22
- Misses 319 338 +19
- Partials 26 27 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution. I especially liked how you separated out some functionality into hr_itm. I have only one minor comment.
pre-commit check is failing. Please fix that. Then we can merge. |
Odoo and OCB builds failing:
|
Also, the pre-commit test is failing. Please click the "Details" link to the right to get the test logs |
Looks good. I figured out how to run the test module and installed gen-odoo-readme on my server. |
Fixes related to version 16.0, some improvements and bug fixes, tested on a real database.