Skip to content

Commit

Permalink
Fix echobreakdown
Browse files Browse the repository at this point in the history
  • Loading branch information
trevorm4 committed Jun 19, 2024
1 parent 7be1352 commit 67321f0
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions src/analysis/retail/evoker/preservation/constants.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import ITEMS from 'common/ITEMS';
import SPELLS from 'common/SPELLS';
import { TALENTS_EVOKER } from 'common/TALENTS';

Expand Down Expand Up @@ -43,7 +42,7 @@ export const DUPLICATION_SPELLS = [
SPELLS.EMERALD_COMMUNION_ALLY.id,
SPELLS.FLUTTERING_SEEDLINGS_HEAL.id,
TALENTS_EVOKER.ECHO_TALENT.id,
ITEMS.BROODKEEPERS_PROMISE_HEAL.id, // adding this here because everyone is running it
SPELLS.ENGULF_HEAL.id,
]; // common spell ids that trigger heal duplication for Cycle of Life and Lifebind

// heal events that can be caused by an echo heal
Expand All @@ -58,6 +57,7 @@ export const ECHO_HEALS = [
SPELLS.VERDANT_EMBRACE_HEAL,
SPELLS.LIFEBIND_HEAL,
SPELLS.GOLDEN_HOUR_HEAL,
SPELLS.ENGULF_HEAL,
];

export const STASIS_CAST_IDS = [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ class EchoBreakdown extends Analyzer {
}

statistic() {
const echoData = this.getEchoDataItems;
const echoData = this.getEchoDataItems();
if (!echoData.length) {
return null;
}
Expand All @@ -269,12 +269,12 @@ class EchoBreakdown extends Analyzer {
<SpellLink spell={TALENTS_EVOKER.ECHO_TALENT} /> <small>breakdown by spell</small>
</>
}
position={STATISTIC_ORDER.OPTIONAL(13)}
category={STATISTIC_CATEGORY.TALENTS}
position={STATISTIC_ORDER.CORE(1)}
wide
smallTitle
wide
>
<TalentAggregateBars bars={this.getEchoDataItems()} wide></TalentAggregateBars>
<TalentAggregateBars bars={this.getEchoDataItems()}></TalentAggregateBars>
</TalentAggregateStatisticContainer>
);
}
Expand Down

0 comments on commit 67321f0

Please sign in to comment.