Code Review

trevorm4 · Oct 24, 2024 · e3ec535 · e3ec535
1 parent 8ba7b64
commit e3ec535
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/src/analysis/retail/evoker/preservation/modules/talents/ConsumeFlame.tsx b/src/analysis/retail/evoker/preservation/modules/talents/ConsumeFlame.tsx
@@ -25,6 +25,7 @@ interface CastInfo {
   coyActive: boolean;
   temporalCompressionStacks: number;
   dreamBreathOnTarget: boolean;
+  targetsHit: number;
 }
 
 class ConsumeFlame extends Analyzer {
@@ -89,14 +90,13 @@ class ConsumeFlame extends Analyzer {
       dreamBreathOnTarget: dreamBreathOnTarget,
       temporalCompressionStacks: temporalCompressionStacks,
       coyActive: coyActive,
+      targetsHit: 0,
     });
   }
 
   onHeal(event: HealEvent) {
-    const players = Object.values(this.combatants.players);
-    const castTargetIsPlayer = players.find((player) => player.id === event.targetID);
-
-    if (castTargetIsPlayer) {
+    const target = this.combatants.getEntity(event);
+    if (target) {
       this.totalHits += 1;
     }
   }
@@ -152,6 +152,7 @@ class ConsumeFlame extends Analyzer {
         <>
           <SpellLink spell={TALENTS_EVOKER.ENGULF_TALENT} /> @{' '}
           {this.owner.formatTimestamp(cast.timestamp)} <br />
+          Targets hit: {}
           <SpellLink spell={TALENTS_EVOKER.DREAM_BREATH_TALENT} /> on target:{' '}
           {cast.dreamBreathOnTarget ? 'Yes' : 'No'} <br />
           {this.selectedCombatant.has4PieceByTier(TIERS.TWW1) && (
@@ -180,7 +181,7 @@ class ConsumeFlame extends Analyzer {
           </strong>
           <div style={{ marginLeft: '1em' }}>
             {this.averageNumTargets.toFixed(1)}
-            <small> avg targets hit</small>
+            <small> avg players hit</small>
           </div>
           <PerformanceBoxRow values={entries} />
         </RoundedPanel>