Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster #11

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Faster #11

wants to merge 3 commits into from

Conversation

shiver
Copy link

@shiver shiver commented Sep 29, 2014

Made some small changes to allow the name files to be cached and also making use of multiprocessing to aid in generating a large number of names a little quicker.

Not a wonderful change, but your project helped me out in testing so I thought I would at least share my changes. Feel free to use it if you want.

Thanks

@coveralls
Copy link

Coverage Status

Coverage decreased (-27.08%) when pulling 8e5685e on shiver:faster into e6aa9db on treyhunner:master.

@treyhunner
Copy link
Owner

Thanks for the pull request @shiver. I don't have a particular need for these changes right now and I prefer to have tests for all new additions.

For now, I will leave this pull request open for others to see, use, and comment on. I might look into this and merge it in the future. :octocat:

@shiver
Copy link
Author

shiver commented Oct 1, 2014

No worries.

The patch is a bit "hacky", since I just made the quick adjustments for my needs.
If I get the chance I may tidy it up a bit and add some tests.

Thanks again for project. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants