feat(unstaking): Instant unstake forecasting #12122

EvgeniiVoznyuk · 2024-04-24T07:44:35Z

Description

Instant unstake forecasting is added to the eth unstaking modal

Related Issue

Resolve trezor#11402

Screenshots:

packages/suite/src/support/messages.ts

packages/suite-data/files/translations/en.json

tomasklim · 2024-04-25T15:54:12Z

Screen.Recording.2024-04-25.at.17.49.11.mov

Would be nice to see max amount there

packages/suite/src/hooks/wallet/useUnstakeEthForm.ts

mroz22 · 2024-10-09T04:45:06Z

packages/connect/src/api/ethereum/api/ethereumCall.ts

@@ -0,0 +1,65 @@
+// origin: https://github.com/trezor/connect/blob/develop/src/js/core/methods/EthereumCall.js


this link does not exist

removed, 77ca47b

mroz22 · 2024-10-09T04:46:39Z

packages/connect/src/api/ethereum/api/ethereumCall.ts

+    request: EthereumCallSchema;
+};
+
+export default class EthereumCall extends AbstractMethod<'ethereumCall', Params> {


why not prefix it with blockchain.. similarly to other blockchain-link interfacing methods? I'd like to know your motivation for this naming

mroz22

please reorganize commits in the way that blockchain-link is a standalone commit and connect is a standalone commit.

tomasklim · 2024-10-09T11:46:30Z

I know it is called ethereumCall in BlockBook, but I would probably call it rpcCall (or something else) in the connect codebase so that it is also ready for other networks (just in case).

(probably makes sense to give it better name in blockbook too)

marekrjpolak · 2024-10-09T12:14:13Z

@tomasklim @mroz22 method name ethereumCall and the fact it's located in api/ethereum/api/* ensures that code splitting will work as expected and the method will be in the correct bundle, which is now ethereum* for all EVM shitcoins. (see https://github.com/trezor/trezor-suite/blob/develop/packages/connect/src/core/method.ts)

If and only if we're 💯 sure there will never be any coin-specific 3rd party dependency related to this method, I'm not against prefixing it with blockchain*, renaming to something eth-unrelated or whatever.

tomasklim · 2024-10-09T13:24:33Z

please reorganize commits in the way that blockchain-link is a standalone commit and connect is a standalone commit.

done

...ents/suite/modals/ReduxModal/UserContextModal/UnstakeModal/UnstakeEthForm/UnstakeEthForm.tsx

.../src/views/wallet/staking/components/EthStakingDashboard/components/ApproximateEthAmount.tsx

packages/blockchain-link-types/src/params.ts

tomasklim · 2024-10-10T09:03:33Z

In case you run into troubles. The blockbook api ethCall is going to be renamed. Please check https://holesky1.trezor.io/test-websocket.html if it is still called ethCall or if it got renamed already.

it should be rpcCall

dev-pvl · 2024-10-14T12:15:43Z

@tomasklim, I added fixes and rebased everything. What do we decide with renaming? For now, I only renamed ethCall to rpcCall where needed.

packages/connect/src/types/api/ethereumCall.ts

tomasklim

Please squash and rebase, there are conflicts.

Any ideas how to test it? right now it does not show any interchanges on holesky/eth

packages/suite/src/utils/suite/stake.ts

...ents/suite/modals/ReduxModal/UserContextModal/UnstakeModal/UnstakeEthForm/UnstakeEthForm.tsx

dev-pvl · 2024-10-21T15:36:20Z

@tomasklim I added the changes you asked for. The easiest way to test it locally is to change const interchanges = 0; to 1 or any non-zero value in suite/src/utils/suite/stake.ts simulateUnstake() method.

tomasklim · 2024-10-26T10:05:35Z

@dev-pvl and what is the reason to have there 0? What number of interchanges do we use for unstake?

tomasklim

LGTM

However, I do not understand why it is visible only when interchanges is greater than 0. Why do we implement it when we do not increase this number for simulation of unstake and unstake itself?

with interchanges = 1

waiting for greens here #15085

EvgeniiVoznyuk requested review from MiroslavProchazka and komret as code owners April 24, 2024 07:44

EvgeniiVoznyuk closed this Apr 24, 2024

EvgeniiVoznyuk reopened this Apr 24, 2024

EvgeniiVoznyuk force-pushed the feat/unstake-eth-instant-forecasting branch from b8197c2 to afe26fb Compare April 24, 2024 08:12

tomasklim self-requested a review April 25, 2024 15:18

tomasklim reviewed Apr 25, 2024

View reviewed changes

packages/suite/src/support/messages.ts Outdated Show resolved Hide resolved

tomasklim reviewed Apr 25, 2024

View reviewed changes

packages/suite-data/files/translations/en.json Outdated Show resolved Hide resolved

This comment was marked as outdated.

Sign in to view

tomasklim reviewed Apr 25, 2024

View reviewed changes

packages/suite/src/hooks/wallet/useUnstakeEthForm.ts Outdated Show resolved Hide resolved

tomasklim requested changes Apr 25, 2024

View reviewed changes

packages/suite/src/hooks/wallet/useUnstakeEthForm.ts Outdated Show resolved Hide resolved

EvgeniiVoznyuk force-pushed the feat/unstake-eth-instant-forecasting branch from 6b016e8 to b65e608 Compare April 29, 2024 06:24

komret removed their request for review August 5, 2024 09:25

tomasklim added the blocked Blocked by external force. Third party inputs required. label Aug 6, 2024

tomasklim removed the blocked Blocked by external force. Third party inputs required. label Sep 25, 2024

dev-pvl force-pushed the feat/unstake-eth-instant-forecasting branch from b65e608 to f0507c1 Compare October 2, 2024 09:32

dev-pvl requested review from mroz22, szymonlesisz, martykan and marekrjpolak as code owners October 8, 2024 11:18

mroz22 reviewed Oct 9, 2024

View reviewed changes

mroz22 requested changes Oct 9, 2024

View reviewed changes

tomasklim added the staking label Oct 9, 2024

tomasklim force-pushed the feat/unstake-eth-instant-forecasting branch from c68d31b to e3cc1f5 Compare October 9, 2024 13:23

tomasklim requested changes Oct 9, 2024

View reviewed changes

dev-pvl force-pushed the feat/unstake-eth-instant-forecasting branch from ec4efe1 to 24f1a0d Compare October 14, 2024 12:07

mroz22 reviewed Oct 15, 2024

View reviewed changes

packages/connect/src/types/api/ethereumCall.ts Outdated Show resolved Hide resolved

tomasklim requested changes Oct 18, 2024

View reviewed changes

packages/suite/src/utils/suite/stake.ts Outdated Show resolved Hide resolved

...ents/suite/modals/ReduxModal/UserContextModal/UnstakeModal/UnstakeEthForm/UnstakeEthForm.tsx Outdated Show resolved Hide resolved

dev-pvl force-pushed the feat/unstake-eth-instant-forecasting branch from 24f1a0d to 1807f1e Compare October 21, 2024 10:49

tomasklim self-requested a review October 21, 2024 17:44

tomasklim added 3 commits October 26, 2024 11:44

feat(blockchain-link): implement ethereum rpc call

db9824d

feat(connect): implement ethereum rpc call

8ab607c

feat(suite): add staking/unstaking instant amount forecasting

3f593fe

tomasklim requested a review from mroz22 October 26, 2024 09:53

tomasklim force-pushed the feat/unstake-eth-instant-forecasting branch from 9e1a100 to 3f593fe Compare October 26, 2024 09:53

tomasklim approved these changes Oct 26, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(unstaking): Instant unstake forecasting #12122

feat(unstaking): Instant unstake forecasting #12122

EvgeniiVoznyuk commented Apr 24, 2024 •

edited by tomasklim

Loading

tomasklim commented Apr 25, 2024

This comment was marked as outdated.

mroz22 Oct 9, 2024

dev-pvl Oct 14, 2024

mroz22 Oct 9, 2024 •

edited

Loading

mroz22 left a comment

tomasklim commented Oct 9, 2024 •

edited

Loading

marekrjpolak commented Oct 9, 2024 •

edited

Loading

tomasklim commented Oct 9, 2024

tomasklim commented Oct 10, 2024

dev-pvl commented Oct 14, 2024

tomasklim left a comment •

edited

Loading

dev-pvl commented Oct 21, 2024

tomasklim commented Oct 26, 2024

tomasklim left a comment •

edited

Loading

		@@ -0,0 +1,65 @@
		// origin: https://github.com/trezor/connect/blob/develop/src/js/core/methods/EthereumCall.js

feat(unstaking): Instant unstake forecasting #12122

Are you sure you want to change the base?

feat(unstaking): Instant unstake forecasting #12122

Conversation

EvgeniiVoznyuk commented Apr 24, 2024 • edited by tomasklim Loading

Description

Related Issue

Screenshots:

tomasklim commented Apr 25, 2024

This comment was marked as outdated.

mroz22 Oct 9, 2024

Choose a reason for hiding this comment

dev-pvl Oct 14, 2024

Choose a reason for hiding this comment

mroz22 Oct 9, 2024 • edited Loading

Choose a reason for hiding this comment

mroz22 left a comment

Choose a reason for hiding this comment

tomasklim commented Oct 9, 2024 • edited Loading

marekrjpolak commented Oct 9, 2024 • edited Loading

tomasklim commented Oct 9, 2024

tomasklim commented Oct 10, 2024

dev-pvl commented Oct 14, 2024

tomasklim left a comment • edited Loading

Choose a reason for hiding this comment

dev-pvl commented Oct 21, 2024

tomasklim commented Oct 26, 2024

tomasklim left a comment • edited Loading

Choose a reason for hiding this comment

EvgeniiVoznyuk commented Apr 24, 2024 •

edited by tomasklim

Loading

mroz22 Oct 9, 2024 •

edited

Loading

tomasklim commented Oct 9, 2024 •

edited

Loading

marekrjpolak commented Oct 9, 2024 •

edited

Loading

tomasklim left a comment •

edited

Loading

tomasklim left a comment •

edited

Loading