-
-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(unstaking): Instant unstake forecasting #12122
base: develop
Are you sure you want to change the base?
feat(unstaking): Instant unstake forecasting #12122
Conversation
b8197c2
to
afe26fb
Compare
Screen.Recording.2024-04-25.at.17.49.11.movWould be nice to see max amount there |
This comment was marked as outdated.
This comment was marked as outdated.
6b016e8
to
b65e608
Compare
b65e608
to
f0507c1
Compare
@@ -0,0 +1,65 @@ | |||
// origin: https://github.com/trezor/connect/blob/develop/src/js/core/methods/EthereumCall.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this link does not exist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed, 77ca47b
request: EthereumCallSchema; | ||
}; | ||
|
||
export default class EthereumCall extends AbstractMethod<'ethereumCall', Params> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not prefix it with blockchain..
similarly to other blockchain-link interfacing methods? I'd like to know your motivation for this naming
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please reorganize commits in the way that blockchain-link is a standalone commit and connect is a standalone commit.
I know it is called (probably makes sense to give it better name in blockbook too) |
@tomasklim @mroz22 method name If and only if we're 💯 sure there will never be any coin-specific 3rd party dependency related to this method, I'm not against prefixing it with |
c68d31b
to
e3cc1f5
Compare
done |
...ents/suite/modals/ReduxModal/UserContextModal/UnstakeModal/UnstakeEthForm/UnstakeEthForm.tsx
Outdated
Show resolved
Hide resolved
...ents/suite/modals/ReduxModal/UserContextModal/UnstakeModal/UnstakeEthForm/UnstakeEthForm.tsx
Outdated
Show resolved
Hide resolved
...ents/suite/modals/ReduxModal/UserContextModal/UnstakeModal/UnstakeEthForm/UnstakeEthForm.tsx
Outdated
Show resolved
Hide resolved
...ents/suite/modals/ReduxModal/UserContextModal/UnstakeModal/UnstakeEthForm/UnstakeEthForm.tsx
Outdated
Show resolved
Hide resolved
...ents/suite/modals/ReduxModal/UserContextModal/UnstakeModal/UnstakeEthForm/UnstakeEthForm.tsx
Outdated
Show resolved
Hide resolved
.../src/views/wallet/staking/components/EthStakingDashboard/components/ApproximateEthAmount.tsx
Outdated
Show resolved
Hide resolved
.../src/views/wallet/staking/components/EthStakingDashboard/components/ApproximateEthAmount.tsx
Outdated
Show resolved
Hide resolved
.../src/views/wallet/staking/components/EthStakingDashboard/components/ApproximateEthAmount.tsx
Outdated
Show resolved
Hide resolved
In case you run into troubles. The blockbook api it should be |
ec4efe1
to
24f1a0d
Compare
@tomasklim, I added fixes and rebased everything. What do we decide with renaming? For now, I only renamed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash and rebase, there are conflicts.
Any ideas how to test it? right now it does not show any interchanges on holesky/eth
...ents/suite/modals/ReduxModal/UserContextModal/UnstakeModal/UnstakeEthForm/UnstakeEthForm.tsx
Outdated
Show resolved
Hide resolved
24f1a0d
to
1807f1e
Compare
@tomasklim I added the changes you asked for. The easiest way to test it locally is to change |
9e1a100
to
3f593fe
Compare
@dev-pvl and what is the reason to have there |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
However, I do not understand why it is visible only when interchanges
is greater than 0
. Why do we implement it when we do not increase this number for simulation of unstake and unstake itself?
waiting for greens here #15085
Description
Instant unstake forecasting is added to the eth unstaking modal
Related Issue
Resolve trezor#11402
Screenshots: