feat: implement random strategy for utxo sorting #14993
Open
+183
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter-sanderson
force-pushed
the
add-random-strategy-for-utxo-sorting
branch
2 times, most recently
from
6d5a084
to
6471734
Compare
peter-sanderson
requested review from
szymonlesisz,
mroz22 and
martykan
as code owners
peter-sanderson
force-pushed
the
add-random-strategy-for-utxo-sorting
branch
2 times, most recently
from
e08aab6
to
d3c713a
Compare
peter-sanderson
commented
Oct 22, 2024
peter-sanderson
force-pushed
the
add-random-strategy-for-utxo-sorting
branch
2 times, most recently
from
c6fcbc1
to
f416200
Compare
Lemonexe
reviewed
Oct 22, 2024
peter-sanderson
force-pushed
the
add-random-strategy-for-utxo-sorting
branch
from
f416200
to
e6c9977
Compare
Lemonexe
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
LGTM 🚀 🎲
But it'd be great if someone more knowledgable took a look at the randomSortingStrategy itself - the implementation makes sense to me, but it's not trivial 🙂
Mostly minor comments on codestyle & tests.
But I'd make the tests more thorough, see comment.
peter-sanderson
force-pushed
the
add-random-strategy-for-utxo-sorting
branch
3 times, most recently
from
2e0a9f0
to
131b6aa
Compare
Lemonexe
approved these changes
Oct 23, 2024
peter-sanderson
force-pushed
the
add-random-strategy-for-utxo-sorting
branch
5 times, most recently
from
2669abd
to
a6e0b6b
Compare
chore: improve test for composeTx so that random number generotor can be mocked per-case in fixure independently
…n mocked randomness
peter-sanderson
force-pushed
the
add-random-strategy-for-utxo-sorting
branch
from
a6e0b6b
to
7cd9899
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a replacement of BIP69 with random sorting. See the linked issue for explanation.
Resolves #10765