Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(staking): zero amounts when bumping fee #15030

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

dev-pvl
Copy link
Contributor

@dev-pvl dev-pvl commented Oct 23, 2024

Description

Resolves zero amount issue when bumping fee during the unstake flow.

Related Issue

Resolve #13752

Screenshots:

bump-fee-zero-amount

@tomasklim tomasklim force-pushed the fix/staking-zero-amounts-when-bumping-fee branch from 51e001e to 6ada92e Compare October 23, 2024 11:04
@tomasklim tomasklim force-pushed the fix/staking-zero-amounts-when-bumping-fee branch from 6ada92e to ec65227 Compare October 23, 2024 17:08
@tomasklim tomasklim force-pushed the fix/staking-zero-amounts-when-bumping-fee branch from ec65227 to 98029fd Compare October 23, 2024 17:19
@tomasklim tomasklim mentioned this pull request Oct 23, 2024
Copy link
Member

@tomasklim tomasklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing approve as in claiming tx, the amount is still 0

@dev-pvl
Copy link
Contributor Author

dev-pvl commented Oct 25, 2024

this fixup 2090878 hides zero amount for bump txs when claiming as was agreed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zero amounts when bumping fee of unstaking and claiming txs
2 participants