-
-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(suite-native): enable device PIN protection card for model T1B1 #15040
Conversation
suite-native/module-authorize-device/src/components/connect/PinFormControlButtons.tsx
Outdated
Show resolved
Hide resolved
suite-native/module-authorize-device/src/components/connect/PinFormProgress.tsx
Outdated
Show resolved
Hide resolved
suite-native/module-authorize-device/src/components/connect/PinOnKeypad.tsx
Outdated
Show resolved
Hide resolved
suite-native/module-device-settings/src/navigation/DevicePinProtectionStackNavigator.tsx
Outdated
Show resolved
Hide resolved
suite-native/module-device-settings/src/navigation/DevicePinProtectionStackNavigator.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job on that. It works like a charm 🚀
suite-native/module-device-settings/src/screens/DeviceInteractionScreen.tsx
Outdated
Show resolved
Hide resolved
@@ -102,12 +107,14 @@ export const DevicePinActionButton = ({ | |||
}); | |||
|
|||
const { param, successMessageKey, canceledMessageKey } = actionConfigMap[type]; | |||
|
|||
const result = await TrezorConnect.changePin({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also please wrap this in deviceAccess request call https://github.com/trezor/trezor-suite/blob/af34896eb90028cc6b7a43795772dcc61e107bd8/suite-native/device-mutex/src/requestDeviceAccess.ts. All the device interaction of suite-native should use it to avoid concurrent access to the device memory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, thanks.
3d27f6d
to
dfec2b6
Compare
Related Issues
#14615 #14616
Screenshots: