feat(suite-native): enable device PIN protection card for model T1B1 #15040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vytick
reviewed
Oct 23, 2024
suite-native/module-authorize-device/src/components/connect/PinFormControlButtons.tsx
Outdated
Show resolved
Hide resolved
suite-native/module-authorize-device/src/components/connect/PinFormProgress.tsx
Outdated
Show resolved
Hide resolved
suite-native/module-authorize-device/src/components/connect/PinOnKeypad.tsx
Outdated
Show resolved
Hide resolved
suite-native/module-device-settings/src/navigation/DevicePinProtectionStackNavigator.tsx
Outdated
Show resolved
Hide resolved
suite-native/module-device-settings/src/navigation/DevicePinProtectionStackNavigator.tsx
Outdated
Show resolved
Hide resolved
PeKne
approved these changes
Oct 24, 2024
suite-native/module-device-settings/src/screens/DeviceInteractionScreen.tsx
Outdated
Show resolved
Hide resolved
PeKne
reviewed
Oct 24, 2024
| @@ -102,12 +107,14 @@ export const DevicePinActionButton = ({ | |||
| }); | |||
|
|
|||
| const { param, successMessageKey, canceledMessageKey } = actionConfigMap[type]; | |||
|
|
|||
| const result = await TrezorConnect.changePin({ | |||
There was a problem hiding this comment.
Also please wrap this in deviceAccess request call https://github.com/trezor/trezor-suite/blob/af34896eb90028cc6b7a43795772dcc61e107bd8/suite-native/device-mutex/src/requestDeviceAccess.ts. All the device interaction of suite-native should use it to avoid concurrent access to the device memory.
vytick
approved these changes
Oct 24, 2024
yanascz
force-pushed
the
feat/device-pin-protection-t1
branch
from
3d27f6d
to
dfec2b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#14615 #14616
Screenshots: