Skip to content

Commit

Permalink
feat: supporting extra envs
Browse files Browse the repository at this point in the history
  • Loading branch information
JannikZed committed Jan 30, 2025
1 parent 432087f commit 993c6ed
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 1 deletion.
2 changes: 1 addition & 1 deletion charts/saleor-apps/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: saleor-apps
description: A Helm chart for deploying Saleor Apps with shared Redis
type: application
version: 0.2.6
version: 0.3.0
appVersion: "1.0.0"
maintainers:
- name: trieb.work
Expand Down
3 changes: 3 additions & 0 deletions charts/saleor-apps/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ spec:
value: {{ include "saleor-apps.redis.url" $ | quote }}
- name: APL
value: {{ $.Values.common.apl | quote }}
{{- if $appConfig.extraEnvs }}
{{- toYaml $appConfig.extraEnvs | nindent 12 }}
{{- end }}
ports:
- name: http
containerPort: {{ $appConfig.port }}
Expand Down
3 changes: 3 additions & 0 deletions charts/saleor-apps/values-example-prod.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,9 @@ apps:
enabled: true
hostname: test-customer-app-test-saleor.eu.fsn1.trwrk.xyz
port: 8000 # Port that your app listens on. Optional, defaults to 3000
extraEnvs:
- name: MY_CUSTOM_ENV
value: "custom-value"
image:
registry: us-central1-docker.pkg.dev # Required
repository: kencove-prod/kencove-docker-repo/saleor-customer-app # Required
Expand Down
11 changes: 11 additions & 0 deletions charts/saleor-apps/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,16 @@ apps:
# repository: myorg/my-custom-app # Required
# tag: v1.0.0 # Required
# manifestPath: /api/manifest # Optional, defaults to /api/manifest
# extraEnvs: # Optional, array of extra environment variables
# # Example:
# # extraEnvs:
# # - name: MY_CUSTOM_ENV
# # value: "custom-value"
# # - name: SECRET_ENV
# # valueFrom:
# # secretKeyRef:
# # name: my-secret
# # key: secret-key
# ingress:
# enabled: true
# annotations: {}
Expand Down Expand Up @@ -90,6 +100,7 @@ apps:
smtp:
enabled: false
hostname: smtp.apps.example.com
extraEnvs: []
port: 3000
image:
tag: "1.3.0"
Expand Down

0 comments on commit 993c6ed

Please sign in to comment.