Framework: Expand CodeQL job to run on all non-deprecated packages modified at a time #13478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achauphan
added
AT: WIP
achauphan
added
AT2-SpecialApprove
achauphan
added
AT2-SpecialApprove
|
Looks reasonable to me! @achauphan |
achauphan
added
AT2-SpecialApprove
sebrowne
reviewed
Oct 2, 2024
.github/workflows/codeql.yml
Outdated
| cd trilinos_build | ||
|
|
||
| bash ${GITHUB_WORKSPACE}/packages/framework/GenConfig/LoadEnv/load-env.sh --force rhel8_gcc-openmpi_debug_shared_no-kokkos-arch_no-asan_complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables | ||
|
|
||
| cmake -G 'Unix Makefiles' -DTrilinos_ENABLE_TESTS=OFF -DTrilinos_ENABLE_Epetra=OFF -DTrilinos_ENABLE_AztecOO=OFF -DTrilinos_ENABLE_Ifpack=OFF -DTrilinos_ENABLE_ML=OFF -D Trilinos_ENABLE_Triutils=OFF -DTrilinos_ENABLE_Tpetra=ON -DTrilinos_ENABLE_MueLu=ON -DTrilinos_ENABLE_Krino=OFF .. |
There was a problem hiding this comment.
This needs to be changed to build the correct set of packages (the ones modified as part of this PR, but not downstream ones).
Could also use the PR scripts to facilitate this, and maybe add the configure option that turns off downstream packages (something like Trilinos_ENABLE_DOWNSTREAM_PACKAGES ish)? Using GenConfig will likely fix your issues with not finding TPLs.
Squashing all the terrible commits I made while using the GitHub web interface. The interface does not seem to have support for signing with DCO. Includes changes which modify the event triggers to comply with new AT2 specifications, assignment of an AT2 runner to run on, usage of GenConfig to load the environment, and prototype implementation of calling the get-changed-trilinos-packages.sh script. Signed-off-by: Anderson Chauphan <[email protected]>
achauphan
force-pushed
the
expand-codeql
branch
from
5f2a88e to
1809708
Compare
Fix calling of get-changed-trilinos-packages.sh to correctly reference the origin remote. Signed-off-by: Anderson Chauphan <[email protected]>
The GenConfig step is just used to generate a cmake fragment for the configuration. This would fit nicely with the step that generates the other cmake fragment for package enables. Signed-off-by: Anderson Chauphan <[email protected]>
Tidy up workflow file with consistent naming and add newlines between each named step for better readability. Signed-off-by: Anderson Chauphan <[email protected]>
Signed-off-by: Anderson Chauphan <[email protected]>
Add TriBITS cache variables to reduce code built for packages that are not needed. Signed-off-by: Anderson Chauphan <[email protected]>
Signed-off-by: Anderson Chauphan <[email protected]>
Manually disable each deprecated package in the cmake command for CodeQL configuration. Since these are defined on the command line, they should take priority over any of the enables from the package_enables.cmake or the genconfig_fragment.cmake fragments. Signed-off-by: Anderson Chauphan <[email protected]>
achauphan
changed the title
Add default shell setting to CodeQL job specifying to use a `bash -l` login shell to clean the syntax throughout the file where these were being individually specified. Signed-off-by: Anderson Chauphan <[email protected]>
Signed-off-by: Anderson Chauphan <[email protected]>
Signed-off-by: Anderson Chauphan <[email protected]>
Add workflow concurrency cancelation check for previous workflows associated with the same PR. Signed-off-by: Anderson Chauphan <[email protected]>
achauphan
removed
the
AT: WIP
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_python3
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
Using Repos:
Pull Request Author: achauphan |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_python3
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
|
|
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
1 similar comment
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
sebrowne
approved these changes
Nov 6, 2024
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ sebrowne ]! |
|
Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR... |
achauphan
added
the
AT: AUTOMERGE
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Merge on Pull Request# 13478: IS A SUCCESS - Pull Request successfully merged |
trilinos-autotester
removed
the
AT: AUTOMERGE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@trilinos/framework @csiefer2
Motivation
The current CodeQL test configuration will run only on Tpetra and MueLu. We want to expand CodeQL's analysis to include all non-deprecated packages that were modified in a PR (ignore downstream packages).
Doing so will increase build time, so this will need to run on our self-hosted runners being spawned by the AutoTester2.
Related Issues
Testing
Testing CodeQL changes will occur within this PR using the AutoTester2 system while the
[WIP]label is being used.