Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] explicits messages #301

Merged
merged 18 commits into from
Dec 12, 2024
Merged

Conversation

spalmer25
Copy link
Collaborator

depends on #300
Raw messages in tests make them less clear and hard to modify.
This PR adds ways to build and encode messages to better understand and maintain tests.

@spalmer25 spalmer25 self-assigned this Oct 31, 2024
@spalmer25 spalmer25 force-pushed the palmer@functori@test-explicit-messages branch 4 times, most recently from fe3ea89 to cb09e4a Compare October 31, 2024 14:50
@spalmer25 spalmer25 force-pushed the palmer@functori@test-explicit-messages branch from cb09e4a to cd2d346 Compare November 27, 2024 09:09
@spalmer25 spalmer25 changed the base branch from main to palmer@functori@test-add-linter November 29, 2024 09:13
@spalmer25 spalmer25 force-pushed the palmer@functori@test-explicit-messages branch from cd2d346 to 8d1c494 Compare November 29, 2024 12:03
@spalmer25 spalmer25 force-pushed the palmer@functori@test-explicit-messages branch from 8d1c494 to c00cf80 Compare December 12, 2024 13:25
@spalmer25 spalmer25 added the tests test - related isues label Dec 12, 2024
@spalmer25 spalmer25 changed the base branch from palmer@functori@test-add-linter to main December 12, 2024 13:42
@spalmer25 spalmer25 marked this pull request as ready for review December 12, 2024 13:42
BALLOT: str = 'yay'
SMART_ROLLUP_KIND: str = 'arith'

class Micheline:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same name as Micheline unioun described above.

@spalmer25 spalmer25 force-pushed the palmer@functori@test-explicit-messages branch from c00cf80 to 0dc8f67 Compare December 12, 2024 15:37
Copy link
Collaborator

@ajinkyaraj-23 ajinkyaraj-23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajinkyaraj-23 ajinkyaraj-23 merged commit 4a8c7b1 into main Dec 12, 2024
149 of 150 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests test - related isues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants