Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Web][UMA-1213] Joining local sign pages #2442

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Web][UMA-1213] Joining local sign pages #2442

wants to merge 2 commits into from
+230 −1,631

Conversation

dianasavvatina
Copy link
Contributor

@dianasavvatina dianasavvatina commented Mar 3, 2025 •
edited
Loading

Proposed changes

UMA-1213 refactoring: multiple pages for local signing

Types of changes

  • Bugfix
  • New feature
  • Refactor
  • Breaking change
  • UI fix

Steps to reproduce

Screenshots

Add the screenshots of how the app used to look like and how it looks now

Type Before Now
Send tez image image
Send token image image

Checklist

  • Tests that prove my fix is effective or that my feature works have been added
  • Documentation has been added (if appropriate)
  • Screenshots are added (if any UI changes have been made)
  • All TODOs have a corresponding task created (and the link is attached to it)

@vercel Vercel
Copy link

vercel bot commented Mar 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
umami-embed-iframe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 10:19am
umami-embed-iframe-ghostnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 10:19am
umami-v2-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 10:19am
umami-v2-web-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 10:19am

@dianasavvatina dianasavvatina force-pushed the UMA-1213/refactoring-multiple-pages-for-local-signing branch from 20b8b75 to 8fc5686 Compare March 3, 2025 17:12
@dianasavvatina dianasavvatina force-pushed the UMA-1213/refactoring-multiple-pages-for-local-signing branch from 8fc5686 to 4d835aa Compare March 3, 2025 17:19
@dianasavvatina dianasavvatina force-pushed the UMA-1213/refactoring-multiple-pages-for-local-signing branch from 4d835aa to 82be481 Compare March 3, 2025 17:26
@dianasavvatina dianasavvatina force-pushed the UMA-1213/refactoring-multiple-pages-for-local-signing branch from 82be481 to 8fb1ece Compare March 4, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OKendigelyan OKendigelyan Awaiting requested review from OKendigelyan

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dianasavvatina