Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DEVELOPMENT.md: Git merge strategy #19352

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

dominikzalewski
Copy link
Member

@dominikzalewski dominikzalewski commented Oct 11, 2023

Description

Added a hint on when to split to multiple commits. Also improved wording of the whole paragraph.

Release notes

(X) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

@cla-bot cla-bot bot added the cla-signed label Oct 11, 2023
@dominikzalewski dominikzalewski force-pushed the update_readme_commit_strategy branch 2 times, most recently from e62d18e to 79a5d0f Compare October 11, 2023 13:04
@dominikzalewski dominikzalewski changed the title Update readme commit strategy Update DEVELOPMENT.md: Git merge strategy Oct 11, 2023
.github/DEVELOPMENT.md Outdated Show resolved Hide resolved
@dominikzalewski dominikzalewski force-pushed the update_readme_commit_strategy branch from 79a5d0f to 26830ae Compare October 12, 2023 10:38
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % unrelated formatting changes.

.github/DEVELOPMENT.md Outdated Show resolved Hide resolved
@dominikzalewski dominikzalewski force-pushed the update_readme_commit_strategy branch 2 times, most recently from 9e9adfc to b823341 Compare October 17, 2023 16:25
.github/DEVELOPMENT.md Show resolved Hide resolved
@dominikzalewski dominikzalewski force-pushed the update_readme_commit_strategy branch from b823341 to 85aa1e2 Compare October 20, 2023 06:53
@dominikzalewski dominikzalewski force-pushed the update_readme_commit_strategy branch from 85aa1e2 to 59dbe44 Compare October 20, 2023 06:54
@hashhar hashhar marked this pull request as ready for review October 20, 2023 07:14
@hashhar hashhar merged commit 0abfb9a into trinodb:master Oct 20, 2023
.github/DEVELOPMENT.md Outdated Show resolved Hide resolved
@github-actions github-actions bot added this to the 430 milestone Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants