-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DEVELOPMENT.md: Git merge strategy #19352
Merged
hashhar
merged 2 commits into
trinodb:master
from
dominikzalewski:update_readme_commit_strategy
Oct 20, 2023
Merged
Update DEVELOPMENT.md: Git merge strategy #19352
hashhar
merged 2 commits into
trinodb:master
from
dominikzalewski:update_readme_commit_strategy
Oct 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominikzalewski
force-pushed
the
update_readme_commit_strategy
branch
2 times, most recently
from
October 11, 2023 13:04
e62d18e
to
79a5d0f
Compare
dominikzalewski
changed the title
Update readme commit strategy
Update DEVELOPMENT.md: Git merge strategy
Oct 11, 2023
kokosing
reviewed
Oct 12, 2023
dominikzalewski
force-pushed
the
update_readme_commit_strategy
branch
from
October 12, 2023 10:38
79a5d0f
to
26830ae
Compare
hashhar
reviewed
Oct 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % unrelated formatting changes.
dominikzalewski
force-pushed
the
update_readme_commit_strategy
branch
2 times, most recently
from
October 17, 2023 16:25
9e9adfc
to
b823341
Compare
hashhar
approved these changes
Oct 19, 2023
dominikzalewski
force-pushed
the
update_readme_commit_strategy
branch
from
October 20, 2023 06:53
b823341
to
85aa1e2
Compare
dominikzalewski
force-pushed
the
update_readme_commit_strategy
branch
from
October 20, 2023 06:54
85aa1e2
to
59dbe44
Compare
hashhar
approved these changes
Oct 20, 2023
ksobolew
reviewed
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a hint on when to split to multiple commits. Also improved wording of the whole paragraph.
Release notes
(X) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: