Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: service, commands, listeners with injection #26

Open
wants to merge 32 commits into
base: main
Choose a base branch
from

Conversation

tristiisch
Copy link
Owner

@tristiisch tristiisch commented Sep 7, 2024

TODO:

  • Implements MessageQueueService in DiscordService

@tristiisch tristiisch changed the title feat: split commands into multiple files feat: service, commands, listeners with injection Sep 20, 2024
@tristiisch tristiisch force-pushed the feature/commands-split branch 2 times, most recently from fca06ef to 79046dc Compare September 22, 2024 22:57
@tristiisch tristiisch force-pushed the feature/commands-split branch 2 times, most recently from 92b6888 to 28eda9a Compare September 30, 2024 23:47
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 70.69243% with 546 lines in your changes missing coverage. Please review.

Project coverage is 52.33%. Comparing base (39d8fe2) to head (83a3a48).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/pyramid/services/socket_server.py 17.55% 108 Missing ⚠️
src/pyramid/services/message_queue.py 25.55% 67 Missing ⚠️
...ramid/connector/discord/commands/tools/register.py 43.39% 30 Missing ⚠️
src/pyramid/api/services/tools/register.py 78.12% 28 Missing ⚠️
src/pyramid/connector/deezer/client/exceptions.py 50.00% 18 Missing ⚠️
.../pyramid/connector/deezer/client/list_paginated.py 81.70% 15 Missing ⚠️
src/pyramid/services/logger.py 81.01% 15 Missing ⚠️
...c/pyramid/connector/discord/music/player_button.py 51.72% 14 Missing ⚠️
src/pyramid/services/logger_level.py 41.66% 14 Missing ⚠️
src/pyramid/services/discord.py 50.00% 13 Missing ⚠️
... and 49 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
- Coverage   59.82%   52.33%   -7.49%     
==========================================
  Files          18       92      +74     
  Lines        1730     3957    +2227     
==========================================
+ Hits         1035     2071    +1036     
- Misses        695     1886    +1191     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tristiisch tristiisch force-pushed the feature/commands-split branch from 3d5a13a to 848fb3a Compare October 3, 2024 21:05
@tristiisch tristiisch force-pushed the feature/commands-split branch 2 times, most recently from 6a09a12 to 426b276 Compare November 18, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant