-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: Update TRT release branch referenced in model gen file #7693
Open
pvijayakrish
wants to merge
3,418
commits into
r24.10
Choose a base branch
from
pvijayakrish-model-gen
base: r24.10
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* name changes * updated names
* Add documentation on generative sequence * Address comment * Reflect the "iterative" change
Co-authored-by: Ryan McCormick <[email protected]>
…generate_stream endpoint.
…#6620) * Extend request objects lifetime * Remove explicit TRITONSERVER_InferenceRequestDelete * Format fix * Include the inference_request_ initialization to cover RequestNew --------- Co-authored-by: Neelay Shah <[email protected]>
This fixes the issue where python client has `AttributeError: 'NoneType' object has no attribute 'enum_types_by_name' errors after python version is updated.
* Update README and versions for 2.40.0 / 23.11 (#6544) * Removing path construction to use SymLink alternatives * Update version for PyTorch * Update windows Dockerfile configuration * Update triton version to 23.11 * Update README and versions for 2.40.0 / 23.11 * Fix typo * Ading 'ldconfig' to configure dynamic linking in container (#6602) * Point to tekit_backend (#6616) * Point to tekit_backend * Update version * Revert tekit changes (#6640) --------- Co-authored-by: Kris Hung <[email protected]>
* New testing to confirm large request timeout values can be passed and retrieved within Python BLS models.
* Add test for optional internal tensor within an ensemble * Fix up
* Set CMake version to 3.27.7 * Set CMake version to 3.27.7 * Fix double slash typo
* Mlflow plugin fix
* Unify iGPU test build with x86 ARM * adding TRITON_IGPU_BUILD to core build definition; adding logic to skip caffe2plan test if TRITON_IGPU_BUILD=1 * re-organizing some copies in Dockerfile.QA to fix igpu devel build * Pre-commit fix --------- Co-authored-by: kyle <[email protected]>
Co-authored-by: GuanLuo <[email protected]> Co-authored-by: Ryan McCormick <[email protected]> Co-authored-by: Misha Chornyi <[email protected]>
Don't Build `tritonfrontend` for Windows.
Co-authored-by: GuanLuo <[email protected]>
…revent race condition (#7617)
Co-authored-by: Sai Kiran Polisetty <[email protected]>
mc-nv
reviewed
Oct 11, 2024
@@ -512,7 +512,7 @@ chmod -R 777 $FORMATDESTDIR | |||
python3 $SRCDIR/gen_qa_trt_data_dependent_shape.py --models_dir=$DATADEPENDENTDIR | |||
chmod -R 777 $DATADEPENDENTDIR | |||
# Make shared library for custom Hardmax plugin. | |||
(git clone -b release/10.0 https://github.com/NVIDIA/TensorRT.git && \ | |||
(git clone -b release/10.5 https://github.com/NVIDIA/TensorRT.git && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This value is hardcoded and may bother us on next release, I would suggest following:
(git clone -b release/$(echo ${TRT_VERSION} | cut -d . -f -2) https://github.com/NVIDIA/TensorRT.git && \
Sure it's not a very flexible solution, but at least it will give us some time to stay away of changing it each release.
mc-nv
approved these changes
Oct 11, 2024
is it need to be closed in favor of: #7712 |
pvijayakrish
force-pushed
the
pvijayakrish-model-gen
branch
from
January 15, 2025 17:13
ee6c4d4
to
5dcad3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Update TRT release branch referenced in model gen file. Looks like this branch name is currently updated manually and only referenced in one place. Example pipeline is shared in JIRA ticket.
Checklist
<commit_type>: <Title>
Commit Type:
Check the conventional commit type
box here and add the label to the github PR.