build: enabled build behind proxy #7842
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mc-nv
reviewed
Dec 11, 2024
Comment on lines
+1775
to
+1776
| if os.path.exists(os.path.expanduser("~/.docker/config.json")): | ||
| runargs += ["-v", os.path.expanduser("~/.docker/config.json:/root/.docker/config.json")] |
There was a problem hiding this comment.
I don't really like this change.
It's kind of we allow to add something without validation.
We have no control of ~/.docker/config.json entries there why we may be forced to review some false positive issues related to user environment.
I may need a bit more context, sound like user looking for a proxy config during the build process, and I may be mistaken here but the issue happen when we run Docker-out-of-Docker configuration using build.py and user is behind the proxy.
I suppose it's better to add a flag for users --use-user-docker-config and add value accordingly if flag is given.
There was a problem hiding this comment.
I agree a flag may be more appropriate here to be clear on the intent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Adds support to build behind proxy by mount docker/config.json into the container running the build.
Checklist
Agreement
<commit_type>: <Title>pre-commit install, pre-commit run --all)Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
Where should the reviewer start?
Test plan:
run build.py with .docker/config.json - confirm successful build behind proxy
run build.py without .docker/config.json - confirm build fails with apt install error
Caveats:
Background
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)