deploy: add initial vllm worker chart

[whoisj]

This change adds the initial version of the vLLM worker Helm chart.

This is NOT the final values schema.

Includes schema validation and embedded chart scripting to enable default values.

No tests included because we have not yet agreed on the best mechanism to validate Helm charts.

DLIS-7810

[whoisj]

This PR makes me realize that we need to agree on a mechanism for Helm chart validation / testing.

If we can agree to allowing the test to be run using pwsh, then I have an easy way to achieve this. Other wise, we'll need to come up with something reasonable.

[rmccorm4]

@whoisj can you fix the pre-commit failure on all the PRs so the checks pass?

It looks like helm chart templates aren't valid YAML so you'd probably need to exclude them: pre-commit/pre-commit-hooks#420 (comment)

[whoisj]

they not YAML files, they're TCL embedded YAML files. They'll never pass any kind of YAML or TCL linter.

best I can tell, there's no way to "fix" them as they're not broken. Suggestions?

[rmccorm4]

You'd probably need to exclude them: pre-commit/pre-commit-hooks#420 (comment)

[whoisj]

seems to be working now.

[rmccorm4]

Until there are CI tests added for K8s/helm - we can probably modify our gitlab trigger to skip triggering a pipeline when only deploy/ folder is changed to reduce unnecessary pipelines and get faster turnaround time on the PR checks ✅

https://stackoverflow.com/a/63822945

[whoisj]

done.

[alec-flowers]

In the values.yaml file should we follow the best practices outlined in the helm documentation?
https://helm.sh/docs/chart_best_practices/values/#document-valuesyaml

For example

# Configuration options related to the Triton Distributed Worker container image.
image: # (required)

# image is a configuration option related to the Triton Distributed Worker container
image: # (required)

They note the reason being is:

Beginning each comment with the name of the parameter it documents makes it easy to grep out documentation, and will enable documentation tools to reliably correlate doc strings with the parameters they describe.

[alec-flowers]

Should we namespace all these defined template names?
https://helm.sh/docs/chart_best_practices/templates/#names-of-defined-templates

[whoisj]

Sure, why not. It'll be useful for embedding these charts.

[whoisj]

done.

[whoisj]

@alec-flowers I've updated the documentation inside values.yaml per your recommendation. Please let me know if it is sufficient now. Thanks.