-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use contiguous memory layout for neighbor lists #10
Draft
efaulhaber
wants to merge
17
commits into
main
Choose a base branch
from
ef/neighbor-lists-vectorofvectors
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
==========================================
+ Coverage 85.02% 87.60% +2.57%
==========================================
Files 9 10 +1
Lines 207 250 +43
==========================================
+ Hits 176 219 +43
Misses 31 31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
efaulhaber
force-pushed
the
ef/neighbor-lists-vectorofvectors
branch
2 times, most recently
from
May 16, 2024 15:40
87d232f
to
4fbd32d
Compare
efaulhaber
force-pushed
the
ef/neighbor-lists-vectorofvectors
branch
from
May 29, 2024 11:18
4fbd32d
to
eedc1e3
Compare
efaulhaber
force-pushed
the
ef/neighbor-lists-vectorofvectors
branch
4 times, most recently
from
June 7, 2024 14:36
43e4cf6
to
2209334
Compare
efaulhaber
force-pushed
the
ef/neighbor-lists-vectorofvectors
branch
from
June 7, 2024 14:38
2209334
to
69646c3
Compare
efaulhaber
force-pushed
the
ef/neighbor-lists-vectorofvectors
branch
from
June 11, 2024 14:22
69646c3
to
ce9153f
Compare
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #9.
For cheap artificial benchmarks like
count_neighbors
(see #18), the difference is huge. But it's more interesting to see real-life benchmarks, so I ran a 2D TLSPH benchmark (ofinteract!
) on a perturbed rectangular point cloud.The difference on a single thread is <1%:
On 64 threads, we're talking about a 14% speedup for 6.5 million particles and 44% for 26 million particles.
Interestingly, there is absolutely no speedup in 3D. I'm assuming because there is more computation per particle-neighbor pair and the neighbor lists are >3x larger, so cache misses in the neighbor lists are insignificant.
Note that this memory layout is also GPU-compatible, as opposed to the
Vector
ofVectors
.